@Jdlrobson Do you know if we can use ES5 in desktop? Should we change Object.keys to a for in to collect the keys?

I see in https://www.mediawiki.org/wiki/Compatibility#cite_note-1 that from 1.27 IE8 doesn't get JS. Does that mean we can target basic ES5 in desktop? (.forEach, .map, etc)

About ECMAScript < 5 browsers see T128115

In T159164#3067952, @Jhernandez wrote:

@Jdlrobson Do you know if we can use ES5 in desktop? Should we change Object.keys to a for in to collect the keys?

Neither desktop nor mobile currently, we're still in ES3-parsing UA support for at least a little while. In T128115 as @Ricordisamoa says we're looking at upgrading that requirement, but it's certainly not going to happen in the next month or two.

In T159164#3069721, @Jdforrester-WMF wrote:

In T159164#3067952, @Jhernandez wrote:

@Jdlrobson Do you know if we can use ES5 in desktop? [..]

Neither desktop nor mobile currently, we're still in ES3-parsing UA support for at least a little while. [..]

In T159164#3067952, @Jhernandez wrote:

[..] Should we change Object.keys to a for in to collect the keys?

No, I'd recommend keeping it and just adding a dependency on the es5-shim module in the extension registration. This module has a special skip-function to make sure we don't download anything extra on modern browsers. On older browsers, it'll ensure this extra module is loaded to polyfill the missing ES5 methods.

Change 340949 had a related patch set uploaded (by jhernandez):
[mediawiki/extensions/Popups] Specify es5-shim as a dependency

https://gerrit.wikimedia.org/r/340949

Thanks a lot @Ricordisamoa @Jdforrester-WMF @Krinkle

Change 340949 merged by jenkins-bot:
[mediawiki/extensions/Popups] Specify es5-shim as a dependency

https://gerrit.wikimedia.org/r/340949