Customize query in gerrit
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T163839 Phase one: consolidate the JavaScript transforms and associated CSS | |||
| Resolved | • Fjalapeno | T152991 Audit iOS, Android and Mobile Web HTML, CSS, and JS | |||
| Invalid | Mhurd | T159183 Consolidate image overflow logic in applib | |||
| Resolved | • Niedzielski | T159194 Integrate consolidated image overflow logic into Android app |
Event Timeline
Comment Actions
Change 347542 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[mediawiki/extensions/MobileApp@master] Hygiene: consolidate image widening CSS in applib
Comment Actions
Change 347543 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[apps/android/wikipedia@master] Hygiene: consolidate image widening CSS and JS in applib
Comment Actions
@Mhurd, would you mind reviewing these patches for the Android integration? I'm also happy to hop on a Hangout too!
https://gerrit.wikimedia.org/r/#/c/347542/
https://gerrit.wikimedia.org/r/#/c/347543/
Comment Actions
Change 347542 merged by jenkins-bot:
[mediawiki/extensions/MobileApp@master] Hygiene: consolidate image widening CSS in applib
Comment Actions
Change 347543 merged by jenkins-bot:
[apps/android/wikipedia@master] Hygiene: consolidate image widening CSS and JS in applib
Comment Actions
@ABorbaWMF, please verify these steps:
1 Open the app in portrait on a high resolution device
2 Go to the Obama article
3 Verify large images occupy the width the screen
4 Rotate the device to landscape
5 Verify that images occupy a smaller portion of the width of the screen
Thanks!
Comment Actions
Tested on Nexus 4 Android 5.1 and Pixel Android 7.1.1 both running 2.5.195-alpha-2017-04-26
The Pixel is HD and all the images I viewed behaved as expected. I saw no regression on the Nexus 4.