Page MenuHomePhabricator

Integrate consolidated image overflow logic into Android app
Closed, ResolvedPublic

Event Timeline

Mhurd created this task.

Change 347542 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[mediawiki/extensions/MobileApp@master] Hygiene: consolidate image widening CSS in applib

https://gerrit.wikimedia.org/r/347542

Change 347543 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[apps/android/wikipedia@master] Hygiene: consolidate image widening CSS and JS in applib

https://gerrit.wikimedia.org/r/347543

@Mhurd, would you mind reviewing these patches for the Android integration? I'm also happy to hop on a Hangout too!

https://gerrit.wikimedia.org/r/#/c/347542/
https://gerrit.wikimedia.org/r/#/c/347543/

Change 347542 merged by jenkins-bot:
[mediawiki/extensions/MobileApp@master] Hygiene: consolidate image widening CSS in applib

https://gerrit.wikimedia.org/r/347542

Change 347543 merged by jenkins-bot:
[apps/android/wikipedia@master] Hygiene: consolidate image widening CSS and JS in applib

https://gerrit.wikimedia.org/r/347543

@ABorbaWMF, please verify these steps:

1 Open the app in portrait on a high resolution device
2 Go to the Obama article
3 Verify large images occupy the width the screen
4 Rotate the device to landscape
5 Verify that images occupy a smaller portion of the width of the screen

Thanks!

Tested on Nexus 4 Android 5.1 and Pixel Android 7.1.1 both running 2.5.195-alpha-2017-04-26

The Pixel is HD and all the images I viewed behaved as expected. I saw no regression on the Nexus 4.

Dbrant closed this task as Resolved.May 15 2017, 3:12 PM