|Before:||After (20x20px icon size)||After (18x18px icon size)|
|Open||None||T150071 Why do we allow indicator-only buttons?|
|Resolved||Volker_E||T159208 Tag-/CapsuleItemWidget: Use icon instead of indicator for the delete button|
@Pginer-WMF has requested a test with more margin to the 20x20px variant. Therefore repeating from the task description and adding specific tests.
After (20x20px icon size):
After (20x20px icon size & increased margin: 2px each side):
After (20x20px icon size & increased margin: 1px each side):
Honestly, I don't think that extra margin is needed, especially given the different shape of proposed icon with more icon inherit white space.
After (18x18px icon size)
My concern was with the "X" becoming a bit too close to the label. If we want to keep the standard 20px icon size we can adjust the space between the label and the icon.
I made an exploration of some possibilities (F8535674) and I think it works well to do the following:
- Add 1px of additional space between the label and the icon.
- Add 1px of additional space before the label.
The mockups below show the result:
the mockup below shows in blue where to add the extra space: