| Before: | After (20x20px icon size) | After (18x18px icon size) |
|---|---|---|
 |  |  |
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T150071 Why do we allow indicator-only buttons? | |||
| Resolved | Volker_E | T159208 Tag-/CapsuleItemWidget: Use icon instead of indicator for the delete button |
Event Timeline
Comment Actions
Change 340289 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
CapsuleItemWidget: Add breathing space and use icon instead of indicator
Comment Actions
Change 340289 merged by jenkins-bot:
[oojs/ui] CapsuleItemWidget: Add breathing space and use icon instead of indicator
Comment Actions
Change 341494 had a related patch set uploaded (by prtksxna):
[oojs/ui] CapsuleItemWidget: Add breathing space and use icon instead of indicator
Comment Actions
After (20x20px icon size):
After (20x20px icon size & increased margin: 2px each side):
After (20x20px icon size & increased margin: 1px each side):
@Pginer-WMF has requested a test with more margin to the 20x20px variant. Therefore repeating from the task description and adding specific tests.
Before:
After (20x20px icon size):
After (20x20px icon size & increased margin: 2px each side):
After (20x20px icon size & increased margin: 1px each side):
Honestly, I don't think that extra margin is needed, especially given the different shape of proposed icon with more icon inherit white space.
After (18x18px icon size)
Comment Actions
My concern was with the "X" becoming a bit too close to the label. If we want to keep the standard 20px icon size we can adjust the space between the label and the icon.
I made an exploration of some possibilities (F8535674) and I think it works well to do the following:
- Add 1px of additional space between the label and the icon.
- Add 1px of additional space before the label.
The mockups below show the result:
the mockup below shows in blue where to add the extra space:
Comment Actions
Change 341494 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Use icon instead of indicator in Tag-/CapsuleItemWidget
Comment Actions
Change 361912 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] Apex theme: Align appearance of tags' close icon to WikimediaUI theme
Comment Actions
Change 361912 merged by jenkins-bot:
[oojs/ui@master] Apex theme: Align appearance of tags' close icon to WikimediaUI theme