Page MenuHomePhabricator
Create Task
Maniphest T159244

[Bug] Wrongly disabled save button while editing in value view experts
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  • Edit a quantity value.
  • Type 2000+-1. The save button gets enabled.
  • Remove the 1. Save gets disabled.
  • Remove -. Still disabled. This is all expected.
  • Now remove the +. Still disabled.

This was reported somewhere on wikidata.org, but I can not find it any more.

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Add browser test for backspace bug in valueviewmediawiki/extensions/Wikibasemaster+13 -0
Drop parsed text and HTML values earlier in jQuery.valueviewdata-values/value-viewmaster+14 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

thiemowmde created this task.Feb 28 2017, 4:50 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptFeb 28 2017, 4:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
thiemowmde triaged this task as Medium priority.Feb 28 2017, 4:50 PM
thiemowmde added a project: Patch-For-Review.
thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.
thiemowmde moved this task from incoming to in progress on the Wikidata board.
thiemowmde added a parent task: T154484: [Story] Improved keyboard navigation.
gerritbot subscribed.Feb 28 2017, 4:51 PM

Change 331607 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
Drop parsed text and HTML values earlier in jQuery.valueview

https://gerrit.wikimedia.org/r/331607

gerritbot added a comment.Feb 28 2017, 4:51 PM

Change 334671 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
Add browser test for backspace bug in valueview

https://gerrit.wikimedia.org/r/334671

gerritbot added a comment.Mar 13 2017, 2:20 PM

Change 331607 merged by jenkins-bot:
[data-values/value-view] Drop parsed text and HTML values earlier in jQuery.valueview

https://gerrit.wikimedia.org/r/331607

• Aleksey_WMDE updated the task description. (Show Details)Mar 14 2017, 3:35 PM
thiemowmde updated the task description. (Show Details)Mar 14 2017, 3:37 PM
• Aleksey_WMDE updated the task description. (Show Details)Mar 15 2017, 11:15 AM
gerritbot added a comment.Mar 16 2017, 11:43 AM

Change 334671 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Add browser test for backspace bug in valueview

https://gerrit.wikimedia.org/r/334671

thiemowmde closed this task as Resolved.Mar 16 2017, 11:51 AM
thiemowmde removed a project: Patch-For-Review.
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL