Page MenuHomePhabricator

Deprecate non-configuration globals
Open, Needs TriagePublic

Description

These globals introduce global state, making testing hard and introducing subtle bugs. They need to die.

The list includes:

  • $wgAuth
  • $wgContLang
  • $wgLang
  • $wgMemc
  • $wgOut
  • $wgParser
  • $wgRequest
  • $wgTitle
  • $wgUser

Event Timeline

MaxSem created this task.Feb 28 2017, 10:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 28 2017, 10:28 PM
MaxSem updated the task description. (Show Details)Mar 1 2017, 12:53 AM

Should $wgFullyInitialised be added to this list? Usually, constants are used for this purpose. (Especially considering that this global does not appear to be defined false anywhere before it is defined as true)