Page MenuHomePhabricator
Create Task
Maniphest T159284

Deprecate $wgTitle completely
Open, Needs TriagePublic
Actions

Description

See parent task. This is a bug against core, bugs for extensions, if needed, should be subtasks of this one.

See also T25307: Send $wgTitle to the fiery pit from whence it came

Current usages in core: https://codesearch.wmflabs.org/core/?q=%5C%24wgTitle%5Cb&i=nope&files=%5C.php%24&repos=
On WMF deployed code: https://codesearch.wmflabs.org/deployed/?q=%5C%24wgTitle%5Cb&i=nope&files=%5C.php%24&repos=
Everywhere: https://codesearch.wmflabs.org/search/?q=%5C%24wgTitle%5Cb&i=nope&files=%5C.php%24&repos=

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Provide a full trace to GlobalTitleFail debug entriesmediawiki/coremaster+10 -5
Make Parser not depend on $wgTitlemediawiki/coremaster+7 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

MaxSem created this task.Feb 28 2017, 10:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 28 2017, 10:33 PM
gerritbot subscribed.Feb 28 2017, 11:09 PM

Change 340431 had a related patch set uploaded (by MaxSem):
[mediawiki/core] Make Parser not depend on $wgTitle

https://gerrit.wikimedia.org/r/340431

gerritbot added a project: Patch-For-Review.Feb 28 2017, 11:09 PM
Jdforrester-WMF subscribed.Feb 28 2017, 11:21 PM
MaxSem updated the task description. (Show Details)Mar 1 2017, 12:51 AM
SamanthaNguyen updated the task description. (Show Details)Sep 26 2017, 4:57 AM
SamanthaNguyen subscribed.Sep 26 2017, 4:59 AM

Updated - Phalanx is an archived extension, see T176665

Dinoguy1000 updated the task description. (Show Details)Apr 18 2018, 11:38 PM
Restricted Application added a project: Product-Analytics. · View Herald TranscriptApr 18 2018, 11:38 PM
• Phabricator_maintenance removed a project: Product-Analytics.Apr 19 2018, 12:19 AM
BethNaught subscribed.Jul 30 2018, 4:32 PM
Izno subscribed.Aug 31 2018, 10:21 PM
This comment was removed by Izno.
MGChecker subscribed.Sep 19 2018, 11:14 PM
gerritbot added a comment.Nov 2 2018, 11:14 PM

Change 340431 abandoned by MaxSem:
Make Parser not depend on $wgTitle

https://gerrit.wikimedia.org/r/340431

gerritbot added a comment.Dec 20 2019, 1:19 PM

Change 559818 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/core@master] Provide a full trace to GlobalTitleFail debug entries

https://gerrit.wikimedia.org/r/559818

Daimona updated the task description. (Show Details)Jan 1 2020, 6:55 PM
gerritbot added a comment.Jan 6 2020, 7:24 PM

Change 559818 merged by jenkins-bot:
[mediawiki/core@master] Provide a full trace to GlobalTitleFail debug entries

https://gerrit.wikimedia.org/r/559818

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Jan 6 2020, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 6 2020, 8:11 PM
RhinosF1 mentioned this in T165438: Extension MsCatSelect uses deprecated wgTitle in JavaScript code.Apr 28 2020, 9:51 AM
Reedy mentioned this in T266182: Score (in its current disabled state) breaks unstripping for other extensions.Oct 24 2020, 1:22 AM
TTO added a parent task: T25307: Send $wgTitle to the fiery pit from whence it came.Feb 2 2026, 11:20 AM
TTO subscribed.

As noted at T25307, there are four remaining places where core code reads from $wgTitle:

  • Linker - used in the deprecated function Linker::makeExternalLink. Action required - remove uses of this function from extensions so the function can be removed from core.
  • MessageCache - logged in the GlobalTitleFail log
  • RequestContext - logged in the GlobalTitleFail log
  • CommentParser - not logged. $wgTitle is used when various CommentFormatter method are called with $selfLinkTarget === null. Action required - deprecate null parameter values in CommentFormatter?

It would be interesting to know what is being logged in GlobalTitleFail these days...

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits