Tapping 'share' on places popover crashes on iPad
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	JoeWalsh
	Mar 1 2017, 11:00 AM

Description

On an iPad
Open places
Tap 'Share' on the visible popover (or any other popover)

Expected:
Share sheet appears

Actual:
Crash

Related Objects

Mentioned In: rAPIOSd93831d818cd: Merge pull request #1217 from wikimedia/bug/T159323
rAPIOS8a758c0cee73: Merge branch 'develop' into bug/T159323
rAPIOS04475870b42a: Merge branch 'bug/T159323' into alpha
rAPIOSf47c2342af26: Merge branch 'develop' into bug/T159323

Event Timeline

JoeWalsh created this task.Mar 1 2017, 11:00 AM

Restricted Application edited projects, added Wikipedia-iOS-App-Backlog; removed Wikipedia-iOS-App-Backlog (Administrative). · View Herald TranscriptMar 1 2017, 11:00 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@cmadeo @JMinor where should the share popover appear on iPad?

sourceRect == the whole popover

Simulator Screen Shot Mar 1, 2017, 6.04.32 AM.png (2×1 px, 2 MB)

Simulator Screen Shot Mar 1, 2017, 6.10.32 AM.png (2×1 px, 2 MB)

Simulator Screen Shot Mar 1, 2017, 6.10.24 AM.png (2×1 px, 1 MB)

sourceRect == the share button

Simulator Screen Shot Mar 1, 2017, 6.09.00 AM.png (2×1 px, 2 MB)

Simulator Screen Shot Mar 1, 2017, 6.08.49 AM.png (2×1 px, 2 MB)

Simulator Screen Shot Mar 1, 2017, 6.08.53 AM.png (2×1 px, 2 MB)

Neither is ideal due to the double popover effect. We might be able to override this behavior and present it as a giant sheet on the iPad (similar to how it's presented on the iPhone currently).

JoeWalsh triaged this task as High priority.Mar 1 2017, 11:17 AM

JoeWalsh moved this task from Tasks from Product Backlog to Blocked or Waiting on the iOS-app-v5.4.0-Hiking-Boot board.

You saw my crash reports?!

I'd suggest we do it as an action sheet, if not possible, the source being the share button seems better from the screenshots.

I agree with @JMinor, action sheet would be ideal, followed by the last screenshot.

• JMinor moved this task from Blocked or Waiting to Ready for Development on the iOS-app-v5.4.0-Hiking-Boot board.Mar 1 2017, 7:03 PM

JoeWalsh mentioned this in rAPIOSf47c2342af26: Merge branch 'develop' into bug/T159323.Mar 1 2017, 8:48 PM

JoeWalsh moved this task from Ready for Development to Needs Code Review on the iOS-app-v5.4.0-Hiking-Boot board.Mar 1 2017, 8:53 PM

JoeWalsh mentioned this in rAPIOS04475870b42a: Merge branch 'bug/T159323' into alpha.Mar 1 2017, 10:10 PM

JoeWalsh mentioned this in rAPIOS8a758c0cee73: Merge branch 'develop' into bug/T159323.Mar 2 2017, 11:07 AM

Diffusion mentioned this in rAPIOSd93831d818cd: Merge pull request #1217 from wikimedia/bug/T159323.Mar 2 2017, 3:01 PM

JoeWalsh moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.4.0-Hiking-Boot board.Mar 3 2017, 7:47 PM

JoeWalsh moved this task from Needs Testing Criteria to Needs QA on the iOS-app-v5.4.0-Hiking-Boot board.

Testing on iPad Air 2 (iOS 10.2) and Wikipedia app 5.4.0 (1083). This is fixed as tapping Share opened the Share sheet:

Nicholas.tsg moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.4.0-Hiking-Boot board.Mar 4 2017, 11:46 PM

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Mar 6 2017, 7:41 PM

• JMinor closed this task as Resolved.Mar 6 2017, 9:48 PM

	F5961916: Simulator Screen Shot Mar 1, 2017, 6.08.49 AM.png
	Mar 1 2017, 11:14 AM

	F5961911: Simulator Screen Shot Mar 1, 2017, 6.09.00 AM.png
	Mar 1 2017, 11:14 AM

	F5961938: Simulator Screen Shot Mar 1, 2017, 6.08.53 AM.png
	Mar 1 2017, 11:14 AM

	F5961899: Simulator Screen Shot Mar 1, 2017, 6.10.24 AM.png
	Mar 1 2017, 11:14 AM

	F5961889: Simulator Screen Shot Mar 1, 2017, 6.10.32 AM.png
	Mar 1 2017, 11:14 AM

	F5961812: Simulator Screen Shot Mar 1, 2017, 6.04.32 AM.png
	Mar 1 2017, 11:14 AM

	F6138806: T159323 Part 2.PNG
	Mar 4 2017, 11:45 PM

	F6138805: T159323 Part 1.PNG
	Mar 4 2017, 11:45 PM

Tapping 'share' on places popover crashes on iPadClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Tapping 'share' on places popover crashes on iPad
Closed, ResolvedPublic
Actions