Description

Steps to reproduce:

Open VE and add something to the page
Save the page
Now click on the Section edit link to open VE

Observed Result:
Observe that, there is an error "Cannot read property 'target' of undefined" that appears briefly in the console.
If I add something more to the page and again save, there is another error in the console "Uncaught TypeError: Cannot read property 'getToolbarDialogs' of null"

Screen Shot 2017-03-01 at 12.06.06 PM.png (720×714 px, 203 KB)

Screen Shot 2017-03-01 at 12.09.29 PM.png (699×1 px, 196 KB)

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/VisualEditor	master	+1 -1	DesktopArticleTarget: Correctly bind section link handler

Customize query in gerrit

Related Objects

Mentioned In: T151021: Section(?) edit links aren't re-set-up on save, so clicking on section link opens OWE and then switches to NWE on second edit without a refresh
Mentioned Here: T159377: Teardown issue – Getting error "Uncaught TypeError: Cannot read property 'getToolbarDialogs' of null" in the console after saving a new section

Event Timeline

Ryasmeen created this task.Mar 1 2017, 8:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2017, 8:10 PM

The second error also appears when adding new section using NWE, so I reported a separate issue on it here T159377

Change 340776 had a related patch set uploaded (by DLynch):
[mediawiki/extensions/VisualEditor] DesktopArticleTarget: Correctly bind section link handler

https://gerrit.wikimedia.org/r/340776

gerritbot added a project: Patch-For-Review.Mar 2 2017, 5:44 PM

Change 340776 merged by DLynch:
[mediawiki/extensions/VisualEditor] DesktopArticleTarget: Correctly bind section link handler

https://gerrit.wikimedia.org/r/340776

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)).Mar 2 2017, 7:00 PM

Jdforrester-WMF closed this task as Resolved.Mar 2 2017, 10:18 PM

Jdforrester-WMF assigned this task to DLynch.

Jdforrester-WMF triaged this task as Unbreak Now! priority.

Jdforrester-WMF set the point value for this task to 1.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 2 2017, 10:18 PM

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald Transcript

Ryasmeen edited projects, added Verified; removed Patch-For-Review.Mar 2 2017, 10:22 PM

Ryasmeen added a project: Verified-in-Phase0.Mar 7 2017, 9:59 PM

Ryasmeen added a project: Verified-in-Phase2.Mar 9 2017, 11:21 PM

Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.

DLynch mentioned this in T151021: Section(?) edit links aren't re-set-up on save, so clicking on section link opens OWE and then switches to NWE on second edit without a refresh.Oct 16 2017, 5:03 PM

	F5976441: Screen Shot 2017-03-01 at 12.06.06 PM.png
	Mar 1 2017, 8:10 PM

	F5976445: Screen Shot 2017-03-01 at 12.09.29 PM.png
	Mar 1 2017, 8:10 PM

Getting error "Cannot read property 'target' of undefined" while opening VE from section edit link Closed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Getting error "Cannot read property 'target' of undefined" while opening VE from section edit link
Closed, ResolvedPublic1 Estimated Story Points
Actions