Page MenuHomePhabricator
Create Task
Maniphest T159384

Text destroyed, then throws exception when undo-ing
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

  1. Open simple.html
  2. Move the cursor to the start of the heading "What is Lorem Ipsum?"
  3. Press shift+down to select the whole line, and cut it (ctrl+x)
  4. Move the cursor to the start of the document (ctrl+home) and paste (ctrl+v)
  5. Press undo once (ctrl+z). Observe the link at the start of the document "Lorem Ipsum" has disappeared
  6. Press undo again, an exception is thrown.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (c78bd8d9b)mediawiki/extensions/VisualEditormaster+1 -1
Don't add transactions to stack until they've had a chance to failVisualEditor/VisualEditormaster+27 -3
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Mar 1 2017, 9:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2017, 9:25 PM
Esanders triaged this task as High priority.Mar 1 2017, 9:25 PM
Esanders renamed this task from Annotation destroyed, then throws exception when undo-ing to Text destroyed, then throws exception when undo-ing.Mar 1 2017, 9:39 PM

This happens no matter what the first paragraph starts with. It looks like it's deleting a fixed amount of text.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Mar 2 2017, 12:06 AM
Jdforrester-WMF set the point value for this task to 1.
Esanders added a subscriber: Catrope.May 24 2017, 3:33 PM

Bisect blames https://gerrit.wikimedia.org/r/#/c/336435/ (@Catrope) - although this may just have been exposing the bug, as paste behaves differently before this commit.

gerritbot subscribed.May 25 2017, 7:39 AM

Change 355582 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Don't add transactions to stack until they've had a chance to fail

https://gerrit.wikimedia.org/r/355582

gerritbot added a project: Patch-For-Review.May 25 2017, 7:39 AM
gerritbot added a comment.May 25 2017, 10:23 AM

Change 355582 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Don't add transactions to stack until they've had a chance to fail

https://gerrit.wikimedia.org/r/355582

gerritbot added a comment.May 25 2017, 1:42 PM

Change 355616 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c78bd8d9b)

https://gerrit.wikimedia.org/r/355616

gerritbot added a comment.May 30 2017, 7:58 PM

Change 355616 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c78bd8d9b)

https://gerrit.wikimedia.org/r/355616

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).May 30 2017, 8:00 PM
Jdforrester-WMF closed this task as Resolved.May 30 2017, 8:17 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 30 2017, 8:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL