Once T157706 is complete, create a new front-end for xtools-articleinfo. This front-end should basically match the existing front-end, but should implement the following changes:
https://meta.wikimedia.org/wiki/Community_Tech/Rewrite_Xtools/Articleinfo#General_statistics
Don't worry about improving the charts or font rendering for this task. That will be handled in a follow-up task.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Matthewrbowker | T153112 Epic: Rewriting XTools | |||
| Resolved | MusikAnimal | T157602 [Epic] Rewrite XTools: Articleinfo | |||
| Resolved | MusikAnimal | T159395 Build new front-end for xtools-articleinfo |
Okay moving to Needs Review for real this time! Try it out at http://tools.wmflabs.org/xtools-dev/articleinfo/en.wikipedia.org/Google (in particular the month counts)
The only things missing I think are better RTL support and to cleanup the mobile view. Those both need to be worked on XTools as a whole, so save that for another ticket.
Where's the code for this? I don't see it at https://github.com/MusikAnimal/xtools-rebirth
We've been pushing straight to master, cuz that's how we roll 😎
Relevant code is at:
@MusikAnimal: Looks good, except that in the initial form, the tooltip needs to come before the label text since it's floated, otherwise, it wraps to the next line and breaks the layout:
https://github.com/x-tools/xtools-rebirth/blob/8ba427b081ca7ecaca5fbffb0cf8f3fcfdd8af6a/app/Resources/views/macros/forms.html.twig#L5
In other words, you'll want to move <div class="glyphicon glyphicon-info-sign tooltipcss pull-right">...</div> before {{ msg("wiki") }}.
Bah, that's Firefox being Firefox (Bug 488725 was filed 8 years ago!). This can be fixed by adding white-space:normal to the label, so we can still semantically have the contents in the order they appear. This design of the form itself was adapted from the original XTools but we'll probably change it as it isn't at all mobile-friendly. Haven't gotten around to it yet, but the same problem exists with all the tools and not just articleinfo.