Page MenuHomePhabricator
Create Task
Maniphest T159419

Use oojs-ui to buttons/layout
Closed, ResolvedPublic
Actions

Description

We can improve the look and feel of the inspector to use oojs-ui instead of the default look. We should also make all tables have the same width.

Screen Shot 2017-03-02 at 10.42.40 AM.png (480×1 px, 110 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use oojs-ui for buttons and more modern looking tablesmediawiki/extensions/PerformanceInspectormaster+51 -18
Make all tables use the same widthmediawiki/extensions/PerformanceInspectormaster+5 -5
Customize query in gerrit

Related Objects

Event Timeline

Peter created this task.Mar 2 2017, 9:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2017, 9:44 AM
gerritbot subscribed.Mar 2 2017, 11:45 AM

Change 340717 had a related patch set uploaded (by Phedenskog):
[mediawiki/extensions/PerformanceInspector] Make all tables use the same width

https://gerrit.wikimedia.org/r/340717

gerritbot added a project: Patch-For-Review.Mar 2 2017, 11:45 AM
gerritbot added a comment.Mar 6 2017, 9:37 PM

Change 340717 merged by jenkins-bot:
[mediawiki/extensions/PerformanceInspector] Make all tables use the same width

https://gerrit.wikimedia.org/r/340717

Peter moved this task from Inbox, needs triage to To-do: Goals prioritized current Quarter on the Performance-Team board.Mar 9 2017, 9:54 PM
Peter moved this task from To-do: Goals prioritized current Quarter to Doing (old) on the Performance-Team board.Mar 21 2017, 8:49 AM
gerritbot added a comment.Mar 21 2017, 11:45 AM

Change 343852 had a related patch set uploaded (by Phedenskog):
[mediawiki/extensions/PerformanceInspector] Use oojs-ui for buttons and more modern looking tables

https://gerrit.wikimedia.org/r/343852

Peter added a comment.Mar 21 2017, 11:55 AM

It's better than before but maybe we can make it even better :)

Screen Shot 2017-03-21 at 12.53.50 PM.png (1×1 px, 323 KB)

Krinkle closed this task as Resolved.Mar 29 2017, 12:38 AM
Krinkle subscribed.

@Peter Yeah, I've merged it for now. Only comment was:

I'm not sure about is the centred text-align for the <td> containing module names and urls. It looks fine for the headings, percentages and buttons, though.
We already have an override for td.details. Maybe give all <td> first columns a class "mw-pi-inspector-module" or some such that also has text-align left.
Or, alternatively, use a <colgroup> instead of adding a class to each row's first <td> manually.

gerritbot added a comment.Mar 29 2017, 12:47 AM

Change 343852 merged by jenkins-bot:
[mediawiki/extensions/PerformanceInspector@master] Use oojs-ui for buttons and more modern looking tables

https://gerrit.wikimedia.org/r/343852

Ckoerner mentioned this in T180990: The table listing all Newsletters should include more features for discoverablity.Nov 20 2017, 7:28 PM
Krinkle removed a project: Patch-For-Review.May 30 2022, 12:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits