Page MenuHomePhabricator
Create Task
Maniphest T159434

RevisionSlider arrow buttons to big on current master
Closed, ResolvedPublic
Actions

Description

OOjs UI v0.19.4 changed some things that affect the scale of buttons and therefore also the arrows in the RevisionSlider. See the screenshot from the current master:

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/RevisionSlidermaster+18 -24Fix arrow css for OOjs UI v0.19.4
mediawiki/extensions/RevisionSliderwmf/1.29.0-wmf.14+18 -24Fix arrow css for OOjs UI v0.19.4
Customize query in gerrit

Related Objects

Event Timeline

WMDE-Fisch created this task.Mar 2 2017, 11:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2017, 11:03 AM
WMDE-Fisch added projects: archived--TCB-Team, Revision-Slider, WMDE-TechWish, OOUI.Mar 2 2017, 11:04 AM
WMDE-Fisch mentioned this in T159428: RevisionSlider tooltip position broken on RTL languages .Mar 2 2017, 11:10 AM
WMDE-Fisch claimed this task.Mar 2 2017, 11:18 AM
WMDE-Fisch moved this task from Proposed to Sprint ready on the WMDE-TechWish board.
IKhitron added a subscriber: IKhitron.Mar 2 2017, 11:24 AM
gerritbot added a subscriber: gerritbot.Mar 2 2017, 11:46 AM

Change 340718 had a related patch set uploaded (by WMDE-Fisch):
[mediawiki/extensions/RevisionSlider] Fix arrow css for OOjs UI v0.19.4

https://gerrit.wikimedia.org/r/340718

gerritbot added a project: Patch-For-Review.Mar 2 2017, 11:46 AM
WMDE-Fisch mentioned this in rERSLe3794c394f66: Fix arrow css for OOjs UI v0.19.4.Mar 2 2017, 11:47 AM
WMDE-Fisch moved this task from Sprint ready to Currently in sprint on the WMDE-TechWish board.Mar 2 2017, 5:55 PM
gerritbot added a comment.Mar 2 2017, 6:46 PM

Change 340793 had a related patch set uploaded (by Addshore; owner: WMDE-Fisch):
[mediawiki/extensions/RevisionSlider] Fix arrow css for OOjs UI v0.19.4

https://gerrit.wikimedia.org/r/340793

gerritbot added a comment.Mar 2 2017, 6:47 PM

Change 340793 abandoned by Addshore:
Fix arrow css for OOjs UI v0.19.4

https://gerrit.wikimedia.org/r/340793

Addshore mentioned this in rERSL30129bf546c4: Fix arrow css for OOjs UI v0.19.4.Mar 2 2017, 6:47 PM
WMDE-Fisch moved this task from Incoming to Revision Slider on the archived--TCB-Team board.Mar 3 2017, 12:00 PM
WMDE-Fisch mentioned this in rERSL2ee4d4415b55: Fix arrow css for OOjs UI v0.19.4.Mar 3 2017, 2:31 PM
gerritbot added a comment.Mar 4 2017, 5:17 PM

Change 340718 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider] Fix arrow css for OOjs UI v0.19.4

https://gerrit.wikimedia.org/r/340718

Addshore triaged this task as High priority.Mar 4 2017, 5:19 PM
Addshore moved this task from Currently in sprint to Done on the WMDE-TechWish board.
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)).Mar 4 2017, 6:00 PM
Tobi_WMDE_SW closed this task as Resolved.Mar 10 2017, 2:24 PM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Mar 14 2017, 4:04 PM
Volker_E removed a project: Patch-For-Review.Apr 15 2017, 7:15 AM
Volker_E moved this task from Backlog to Waiting for breaking release on the OOUI board.
Volker_E removed a subscriber: gerritbot.
Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 12:00 PM
Volker_E moved this task from Waiting for breaking release to Resolved outside releases on the OOUI board.Mar 22 2018, 5:43 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL