Page MenuHomePhabricator

Add 3d touch action to Explore items to open them in Places
Closed, ResolvedPublic

Description

User stories

Explore feed
While I am looking through my explore feed I sometimes see articles with geographic locations, I'd like to be able to view these articles on a map. I'd like to be able to view the article on a map without having to type in the article name on the Places tab.

Design Constraints

Explore feed

  • Allow users to be able to interact (tap, force press) with location article cells in the same way they were able to before this feature (no overriding of previous interactions)
  • No cell design changes

Explore feed


3D touch on an article cell on the Explore feed for an article with a primary location exposes the peek menu with the added item of 'View on a map.' Clicking on 'View on a map' opens the Places tab map centered on the article's pin.

Prototype

https://wikimedia.invisionapp.com/share/WV9E3UL4H#/206347318_A_01

Zeplin

https://zpl.io/Z21KiN7

Event Timeline

JMinor created this task.Mar 2 2017, 5:32 PM

Note, the "View on a map" option will also appear if peeked in an Article List (fore example, all top read articles for a day) or when peeking another article inside an article view.

Testing on iPhone 6s (iOS 10.2) and Wikipedia app 5.4.0 (1085). This is fixed as 'View on a map' opened on the Places tab when peeking and popping the Explore feed "Random article" Ellsworth Avenue:

ABorbaWMF added a subscriber: ABorbaWMF.

This one may need further review. I noticed a couple of things:
The "View on a map" option is now available on most article in the explore feed, but it does not work well when the article has no location info. For example: Bessie Braddock is the featured article for 3/8/17. Tapping on 'View' in this case doesn't give meaningful results. Perhaps this option should only be shown for article containing location info?

I am seeing 3D touch menus for everything except on the "In the news" card(s). Also within a news list the user cannot 3D touch the list items. Perhaps this is a separate issue?

Moving back to design review for now.

The "View on a map" option is now available on most article in the explore feed, but it does not work well when the article has no location info. For example: Bessie Braddock is the featured article for 3/8/17. Tapping on 'View' in this case doesn't give meaningful results. Perhaps this option should only be shown for article containing location info?

The "View on a map" option was incorrectly being shown for all articles. This should be fixed now.

I am seeing 3D touch menus for everything except on the "In the news" card(s). Also within a news list the user cannot 3D touch the list items. Perhaps this is a separate issue?

Yeah, I think that's a separate issue

I'm going to move it back to QA for the original issue

Tested on 5.4.0 (1086). Looks good on iphone 7+ running iOS 10.2.1. Moving to Ready for PM signoff.

JMinor closed this task as Resolved.May 23 2017, 8:41 PM