Page MenuHomePhabricator

Rephrase enotif_lastdiff and enotif_lastvisited
Closed, ResolvedPublic

Description

Currently, MediaWiki:Enotif lastdiff reads like this:

See $1 to view this change.

The problem is $1 is usually a very long URL, therefore the message looks like this in the email:

See
https://domain.com/w/i.php?title=very_long_title_that_pushes_the_text_down&diff=next&oldid=123456789
to view this change.

This breaks the sentence into multiple lines, making it hard to read. Instead, it should be phrased such that the URL is the last bit in the sentence, i.e. To view this change, see $1

The same applies to the other related messages.

Event Timeline

Huji created this task.Mar 2 2017, 9:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2017, 9:06 PM
Huji triaged this task as Lowest priority.Mar 2 2017, 9:06 PM
Huji renamed this task from Rephrase the Enotif lastdiff and related messages to Rephrase enotif_lastdiff and enotif_lastvisited.Mar 2 2017, 9:39 PM

Change 340832 had a related patch set uploaded (by Huji):
[mediawiki/core] Rephrase enotif_lastdiff and enotif_lastvisited

https://gerrit.wikimedia.org/r/340832

Huji updated the task description. (Show Details)Mar 2 2017, 9:40 PM

Change 340832 merged by jenkins-bot:
[mediawiki/core@master] Rephrase enotif_lastdiff and enotif_lastvisited

https://gerrit.wikimedia.org/r/340832

matmarex closed this task as Resolved.Apr 21 2017, 7:32 PM
matmarex removed a project: Patch-For-Review.