When one or more reading lists are deleted (for example), a snackbar appears for a rather long time that obscures the bottom navigation bar and prevents the user from navigating to a different fragment until the snackbar disappears. Snackbars should ideally appear above the bottom navigation component.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Make SnackBars appear above BottomNavigationView. | apps/android/wikipedia | master | +38 -1 |
Event Timeline
Comment Actions
Note: having more than one action in a Snackbar is against Material guidelines.
https://material.io/guidelines/components/snackbars-toasts.html#snackbars-toasts-usage
A more proper implementation might be to have the snackbar appear on top of the navigation bar.
Comment Actions
Change 341338 had a related patch set uploaded (by dbrant):
[apps/android/wikipedia] Make SnackBars appear above BottomNavigationView.
Comment Actions
Change 341338 merged by jenkins-bot:
[apps/android/wikipedia] Make SnackBars appear above BottomNavigationView.
Comment Actions
For QA:
- Go to the Feed, and cause a Snackbar to appear (e.g. add one of the articles to a reading list).
- Make sure that the Snackbar appears above the bottom navigation buttons.
Comment Actions
Appears to be fixed. Tested on Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1 and the Alpha App 2.5.190-alpha-2017-03-08