[BUG] 'Read article' is no longer always shown on the screen in the Article preview sheet.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	Mar 3 2017, 8:11 PM

Description

This appears to be a regression in the latest version of the app.

Steps to reproduce

Open an article (e.g., [[ en.m.wikipedia.org/wiki/Hydrus | Hydrus ]])
Tap on a link (e.g., Constellation) to bring up the article preview card

Expected

Article preview sheet slides up from below partially covering the screen, with the "READ ARTICLE" in an 'action area' fixed to the bottom of the screen.

preview when initially triggered

Expected article preview a.png (640×360 px, 113 KB)

preview dragged up to show full preview content

Expected article preview b - full.png (640×360 px, 135 KB)

Actual

In the latest update the 'Read article' action is now part of the preview content that may not be visible on the screen on initially being triggered.

Screenshot_20170303-120634.png (1×1 px, 425 KB)

Occurring on

Device: Nexus 5
Android OS: 6.0.1
Version: Wikipedia 2.5.190-r-2017-02-24

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Bring back link preview overlay buttons.	apps/android/wikipedia	master	+143 -69

Customize query in gerrit

Related Objects

Duplicates Merged Here: T159573: [BUG] 'Read article' is no longer always shown on the screen in the Article preview sheet.

Event Timeline

RHo created this task.Mar 3 2017, 8:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2017, 8:11 PM

Aklapper added a project: Android-app-Bugs.Mar 4 2017, 5:40 PM

Restricted Application added a project: Wikipedia-Android-App-Backlog. · View Herald TranscriptMar 4 2017, 5:40 PM

Dbrant merged a task: T159573: [BUG] 'Read article' is no longer always shown on the screen in the Article preview sheet..Mar 6 2017, 3:36 PM

Dbrant moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.Mar 8 2017, 4:38 PM

Change 342827 had a related patch set uploaded (by Dbrant):
[apps/android/wikipedia] Bring back link preview overlay buttons.

https://gerrit.wikimedia.org/r/342827

gerritbot added a project: Patch-For-Review.Mar 15 2017, 1:13 PM

Dbrant claimed this task.Mar 15 2017, 1:30 PM

Dbrant added a project: Android-app-release-v2.5.19x-Ananas🍍.

Dbrant moved this task from To Do to Code Review on the Android-app-release-v2.5.19x-Ananas🍍 board.

Change 342827 merged by jenkins-bot:
[apps/android/wikipedia] Bring back link preview overlay buttons.

https://gerrit.wikimedia.org/r/342827

Dbrant moved this task from Code Review to Design Signoff on the Android-app-release-v2.5.19x-Ananas🍍 board.Mar 16 2017, 11:56 AM

main-MainActivity-03172017123736.png (1×1 px, 418 KB)

Device: Pixel
Android OS: 7.1.1
Version: Wikipedia 2.5.190-alpha-2017-03-16

Testing on Samsung Galaxy Express 3 (J120A) with Android 6.0.1 and Wikipedia Alpha app 2.5.190-alpha-2017-03-21. This is fixed according to my screencaps "READ ARTICLE" appears upon initially triggering the preview

T159571 Preview Initially Triggered.png (800×480 px, 118 KB)

as well as with the full preview content

T159571 Full Preview Content.png (800×480 px, 179 KB)

Tested on a Pixel with Android 7.1.1 and the Alpha App 2.5.190-alpha-2017-03-23

This appears to be fixed.

Dbrant moved this task from Ready for Signoff to Done on the Android-app-release-v2.5.19x-Ananas🍍 board.Mar 29 2017, 4:05 PM

Dbrant closed this task as Resolved.Mar 29 2017, 4:06 PM

	F6827974: T159571 Preview Initially Triggered.png
	Mar 21 2017, 9:27 PM

	F6827984: T159571 Full Preview Content.png
	Mar 21 2017, 9:27 PM

	F6664907: main-MainActivity-03172017123736.png
	Mar 17 2017, 11:41 AM

	F6079950: Expected article preview b - full.png
	Mar 3 2017, 8:11 PM

[BUG] 'Read article' is no longer always shown on the screen in the Article preview sheet.Closed, ResolvedPublicActions