Page MenuHomePhabricator
Create Task
Maniphest T159671

IndexSizeError triggered and cascades into failing buttons
Closed, ResolvedPublic2.5 Estimated Story Points
Actions

Description

After the latest deploy the test wiki main page behaves unexpectedly.

Upon attempting to highlight the first utterance a IndexSizeError. This means highlighting fails which in turn means Wikispeech/this.playOrStop is not triggered and thus the play button does not change to a stop button.

On the main page this might be related to T159545: Unicode characters increase length of highlighting but it is unlikely to be the reason for the similar behavior in the second sentence of Blonde_on_Blonde.

Details

SubjectRepoBranchLines +/-
Calculate correct offsets for unicode charactersmediawiki/extensions/Wikispeechmaster+302 -97
Customize query in gerrit

Related Objects

Event Timeline

Lokal_Profil created this task.Mar 6 2017, 9:14 AM
Lokal_Profil updated the task description. (Show Details)Mar 8 2017, 9:57 AM
Lokal_Profil moved this task from Incoming to Proposed for next sprint on the Wikispeech board.
Sebastian_Berlin-WMSE mentioned this in T159545: Unicode characters increase length of highlighting.Mar 15 2017, 12:39 PM
Sebastian_Berlin-WMSE set the point value for this task to 2.5.Mar 22 2017, 11:08 AM
Sebastian_Berlin-WMSE edited projects, added Wikispeech (Sprint 2017-03-22); removed Wikispeech.
Sebastian_Berlin-WMSE subscribed.

This point estimate assumes that this is not resolved by T159545.

Sebastian_Berlin-WMSE mentioned this in rEWISda248ddd4586: Calculate correct offsets for unicode characters.Mar 24 2017, 2:16 PM
Lokal_Profil mentioned this in rEWIS62100113fc9b: Calculate correct offsets for unicode characters.Mar 24 2017, 4:28 PM
gerritbot subscribed.Mar 24 2017, 4:29 PM

Change 344616 had a related patch set uploaded (by Lokal Profil; owner: Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Calculate correct offsets for unicode characters

https://gerrit.wikimedia.org/r/344616

gerritbot added a project: Patch-For-Review.Mar 24 2017, 4:29 PM
Sebastian_Berlin-WMSE mentioned this in rEWIS9eccc4040f3d: Calculate correct offsets for unicode characters.Mar 24 2017, 10:12 PM
Sebastian_Berlin-WMSE mentioned this in rEWIS108d5b654f18: Calculate correct offsets for unicode characters.
gerritbot added a comment.Mar 24 2017, 10:13 PM

Change 344616 had a related patch set uploaded (by Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Calculate correct offsets for unicode characters

https://gerrit.wikimedia.org/r/344616

Sebastian_Berlin-WMSE moved this task from Backlog to In progress on the Wikispeech (Sprint 2017-03-22) board.Mar 27 2017, 9:13 AM
Sebastian_Berlin-WMSE mentioned this in rEWISeab37b863c9c: Calculate correct offsets for unicode characters.Mar 30 2017, 7:43 AM
gerritbot added a comment.Mar 30 2017, 9:32 AM

Change 344616 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Calculate correct offsets for unicode characters

https://gerrit.wikimedia.org/r/344616

Sebastian_Berlin-WMSE moved this task from In progress to Done on the Wikispeech (Sprint 2017-03-22) board.Mar 30 2017, 12:10 PM
Sebastian_Berlin-WMSE closed this task as Resolved.Apr 5 2017, 8:37 AM
Sebastian_Berlin-WMSE claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL