Page MenuHomePhabricator

After switching between VE and NWE save dialog complains about missing summary
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to reproduce (probably it can be reproduced more easily, but these steps work):

  1. Enable VE, NWE, and "Prompt me when entering a blank edit summary"
  2. Edit an article in VE, click "Save changes", enter a summary.
  3. Continue editing, switch to NWE.
  4. Change something, switch back to VE.
  5. Try to save.

Expected:
Saving works without warning.

Actual:
You are warned of a missing summary (though it is present).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 342065 had a related patch set uploaded (by DLynch):
[mediawiki/extensions/VisualEditor] ArticleTarget: use existing initialEditSummary if present

https://gerrit.wikimedia.org/r/342065

Change 342065 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] ArticleTarget: use existing initialEditSummary if present

https://gerrit.wikimedia.org/r/342065

Change 342083 had a related patch set uploaded (by DLynch):
[mediawiki/extensions/VisualEditor] ArticleTarget: Improve edit summary behavior when switching

https://gerrit.wikimedia.org/r/342083

Change 342083 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] ArticleTarget: Improve edit summary behavior when switching

https://gerrit.wikimedia.org/r/342083

Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF removed a project: Patch-For-Review.