ChangesListSpecialPageFilters will be deprecated, so we should use another hook, such as ChangesListSpecialPageQuery, instead. We should also avoid hard-coding them if possible.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Stop using deprecated hook 'ChangesListSpecialPageFilters' | mediawiki/extensions/WikimediaEvents | master | +19 -13 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 348088 had a related patch set uploaded (by Sbisson):
[mediawiki/extensions/WikimediaEvents@master] Stop using deprecated hook 'ChangesListSpecialPageFilters'
Comment Actions
Avoiding the deprecated hook was fixed in T162879: Replace deprecated hook usage ChangesListSpecialPageFilters in WikimediaEvents
Not hardcoding filter names would mean changing the schema from filter names in keys ( { hideminor: true } ) to filter names in values ( { name: 'hideminor", value: true } ). It's not a problem in itself but it means the data before and after will be different and that's added complexity for data analysis.
It would be interesting to have opinions on both schemas from people actually working with this data.
Comment Actions
Change 348088 abandoned by Sbisson:
Stop using deprecated hook 'ChangesListSpecialPageFilters'
Reason:
Was fixed in I25476deab3296828e277174bba15976e7f6d998a
Comment Actions
The patch was for an aspect of this task (usage of deprecated hook) that ended up being handled somewhere else.
Comment Actions
The relevant instrumentation was removed in 2018:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/+/477355