Page MenuHomePhabricator
Create Task
Maniphest T159809

Highlighting fails on bold/italicized utterance
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

Playing wikispeech:T159809 we find that highlighting fails if an utterance is entirely in bold/italics.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Calculate correct offsets for unicode charactersmediawiki/extensions/Wikispeechmaster+302 -97
Customize query in gerrit

Related Objects

Event Timeline

Lokal_Profil created this task.Mar 7 2017, 9:33 AM
Lokal_Profil updated the task description. (Show Details)Mar 7 2017, 9:36 AM
Lokal_Profil renamed this task from Highlighting fails on bold text to Highlighting fails on bold/italicized utterance.Mar 7 2017, 9:39 AM
Lokal_Profil updated the task description. (Show Details)
Sebastian_Berlin-WMSE moved this task from Incoming to Proposed for next sprint on the Wikispeech board.Mar 8 2017, 9:08 AM
Sebastian_Berlin-WMSE added a project: User-Sebastian_Berlin-WMSE.Mar 15 2017, 12:29 PM
Sebastian_Berlin-WMSE mentioned this in T159545: Unicode characters increase length of highlighting.Mar 15 2017, 12:39 PM
Sebastian_Berlin-WMSE set the point value for this task to 0.Mar 22 2017, 11:10 AM
Sebastian_Berlin-WMSE edited projects, added Wikispeech (Sprint 2017-03-22); removed Wikispeech.
Sebastian_Berlin-WMSE subscribed.

This will be solved by T159545.

Sebastian_Berlin-WMSE mentioned this in rEWISda248ddd4586: Calculate correct offsets for unicode characters.Mar 24 2017, 2:16 PM
Lokal_Profil mentioned this in rEWIS62100113fc9b: Calculate correct offsets for unicode characters.Mar 24 2017, 4:28 PM
gerritbot subscribed.Mar 24 2017, 4:29 PM

Change 344616 had a related patch set uploaded (by Lokal Profil; owner: Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Calculate correct offsets for unicode characters

https://gerrit.wikimedia.org/r/344616

gerritbot added a project: Patch-For-Review.Mar 24 2017, 4:29 PM
Sebastian_Berlin-WMSE mentioned this in rEWIS9eccc4040f3d: Calculate correct offsets for unicode characters.Mar 24 2017, 10:12 PM
gerritbot added a comment.Mar 24 2017, 10:13 PM

Change 344616 had a related patch set uploaded (by Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Calculate correct offsets for unicode characters

https://gerrit.wikimedia.org/r/344616

Sebastian_Berlin-WMSE mentioned this in rEWIS108d5b654f18: Calculate correct offsets for unicode characters.Mar 24 2017, 10:13 PM
Sebastian_Berlin-WMSE moved this task from Backlog to This Week on the User-Sebastian_Berlin-WMSE board.Mar 27 2017, 9:11 AM
Sebastian_Berlin-WMSE moved this task from Backlog to In progress on the Wikispeech (Sprint 2017-03-22) board.Mar 27 2017, 9:13 AM
Sebastian_Berlin-WMSE mentioned this in rEWISeab37b863c9c: Calculate correct offsets for unicode characters.Mar 30 2017, 7:43 AM
gerritbot added a comment.Mar 30 2017, 9:32 AM

Change 344616 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Calculate correct offsets for unicode characters

https://gerrit.wikimedia.org/r/344616

Stashbot mentioned this in T159811: Overlapping highlighting.Mar 30 2017, 10:15 AM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-labs) [2017-03-30T10:15:39Z] <Sebastian-WMSE> Deploy latest from Git master: 64cbd96 (T159545, T159811, T159809)

Sebastian_Berlin-WMSE moved this task from This Week to Done on the User-Sebastian_Berlin-WMSE board.Mar 30 2017, 10:16 AM
Sebastian_Berlin-WMSE moved this task from In progress to Done on the Wikispeech (Sprint 2017-03-22) board.Mar 30 2017, 12:10 PM
Lokal_Profil closed this task as Resolved.Apr 5 2017, 8:38 AM
Lokal_Profil assigned this task to Sebastian_Berlin-WMSE.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits