Page MenuHomePhabricator

Overlapping highlighting
Closed, ResolvedPublic0 Estimated Story Points

Description

Highlighting of sentences highlight the space between sentences in both the sentence just before the space and the one just after.

The expected behaviour would be to highlight it in just the sentence before, alternatively to not highlight the space at all.

See e.g. the last two sentences on wikispeech:T159809

Event Timeline

The reason for this behaviour is that the range used for highlighting is increased by one. This is a leftover from when offsets were handled differently.

I think the most natural would be to not highlight any sequences of only whitespaces, that are either at the start or end of a sentence. This would include spaces between sentences.

Lokal_Profil set the point value for this task to 0.Mar 22 2017, 11:10 AM
Lokal_Profil edited projects, added Wikispeech (Sprint 2017-03-22); removed Wikispeech.

This will be solved by T159545

Change 344616 had a related patch set uploaded (by Lokal Profil; owner: Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Calculate correct offsets for unicode characters

https://gerrit.wikimedia.org/r/344616

Change 344616 had a related patch set uploaded (by Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Calculate correct offsets for unicode characters

https://gerrit.wikimedia.org/r/344616

Change 344616 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Calculate correct offsets for unicode characters

https://gerrit.wikimedia.org/r/344616

Mentioned in SAL (#wikimedia-labs) [2017-03-30T10:15:39Z] <Sebastian-WMSE> Deploy latest from Git master: 64cbd96 (T159545, T159811, T159809)