Page MenuHomePhabricator

RC filters - 'Restore default filters' should cancel previous selections of filters' highlighting
Closed, ResolvedPublic


Split from the discussion as per @Pginer-WMF comment:

I agree, the "restore default filters" and the trash can are used to get to a clean slate for the user to start again so it makes sense to clear previous highlighting states.

Steps to reproduce:

  1. A user discards default filters
  2. Then, the user selects only highlighting for the 'Unregistered' filter
  3. The user discards 'Unregistered' highlighting via clicking on the 'Highlight results' button - the filter selection is gone along with the highlighting.
  4. The user clicks on 'Restore default filters' - the filters are restored.
  5. Clicks on the 'Highlight results' button to apply highlighting to the filters present in the capsule.

Clicking on 'Highlight results' will display previously displayed highlights, and also will 'restore' those filters. So the user will see not only default filters that he specifically requested, but also the added highlighted filters from the previous selection that he forgot to dismiss explicitly.

The UI result will be as in the screenshot - the default filters are displayed along with previously selected highlight for the 'Unregistered' filter.

Screen Shot 2017-03-07 at 8.46.07 AM.png (400×779 px, 90 KB)

Event Timeline

Change 341603 had a related patch set uploaded (by Sbisson):
[mediawiki/core] RC Filters UI: 'restore defaults' clears highlight

Change 341603 merged by jenkins-bot:
[mediawiki/core] RC Filters UI: 'restore defaults' clears highlight

@Mooeypoo Regarding your comment

I think this invalidates the ticket T159503: [minor] RC filters -should 'Restore default filters' return 'Highlight results' button to inactive state?

@Pginer-WMF commented on that ticket that selecting 'Highlight results' is like a user preference. So 'Restore default settings' should not cancel that.

Checked the fix in betalabs - the issue is resolved.

QA recommendation: Resolve.