Page MenuHomePhabricator

Don't select an article after Places search unless the search was for that specific article
Closed, ResolvedPublic

Assigned To
Authored By
JoeWalsh
Mar 7 2017, 7:47 PM
Referenced Files
F6576573: T159871 iPad Air 2 Step 1.PNG
Mar 14 2017, 11:05 PM
F6576569: T159871 iPad Air 2 Step 2.PNG
Mar 14 2017, 11:05 PM
F6576596: T159871 iPhone 6s Step 3.PNG
Mar 14 2017, 11:05 PM
F6576609: T159871 iPhone 7 Step 3.PNG
Mar 14 2017, 11:05 PM
F6576594: T159871 iPhone 6s Step 2.PNG
Mar 14 2017, 11:05 PM
F6576611: T159871 iPhone 7 Step 1.PNG
Mar 14 2017, 11:05 PM
F6576608: T159871 iPhone 7 Step 2.PNG
Mar 14 2017, 11:05 PM
F6576574: T159871 iPad Air 2 Step 4.PNG
Mar 14 2017, 11:05 PM

Description

Steps to repro

  1. Search on Places tab for "Top Articles"
  2. Verify that no article is selected after the search
  3. Search for specific article, for example "Paris" and tap the "Paris" suggestion with the location arrow icon
  4. Verify that the "Paris" article is selected

Event Timeline

All devices were tested with Wikipedia 5.4.0 (1094) app. Tested on iPad Air 2/iOS 10.2

T159871 iPad Air 2 Step 1.PNG (2×1 px, 657 KB)
T159871 iPad Air 2 Step 2.PNG (2×1 px, 118 KB)
T159871 iPad Air 2 Step 3.PNG (2×1 px, 171 KB)
T159871 iPad Air 2 Step 4.PNG (2×1 px, 1 MB)

iPhone 6s/iOS 10.2
T159871 iPhone 6s Step 1.PNG (1×750 px, 279 KB)
T159871 iPhone 6s Step 2.PNG (1×750 px, 74 KB)
T159871 iPhone 6s Step 3.PNG (1×750 px, 98 KB)
T159871 iPhone 6s Step 4.PNG (1×750 px, 677 KB)

and iPhone 7/iOS 10.2.1
T159871 iPhone 7 Step 1.PNG (1×750 px, 493 KB)
T159871 iPhone 7 Step 2.PNG (1×750 px, 87 KB)
T159871 iPhone 7 Step 3.PNG (1×750 px, 186 KB)
T159871 iPhone 7 Step 4.PNG (1×750 px, 1 MB)

According to the screencaps this appears to be working as intended.