Page MenuHomePhabricator
Create Task
Maniphest T159876

Use content model to filter for geo-shapes in ui suggestions
Closed, ResolvedPublic
Actions

Description

We would like to only propose valid items in the geo-shape suggester.

We can filter contentModel when using fulltext search we should change this in suggested items list in commonssuggester.js

Details

SubjectRepoBranchLines +/-
Change test to fulltext API search parametersdata-values/value-viewmaster+3 -2
Use fulltext search in commons suggesterdata-values/value-viewmaster+35 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Jonas created this task.Mar 7 2017, 8:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2017, 8:59 PM
• Jonas moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.Mar 7 2017, 9:00 PM
gerritbot added a subscriber: gerritbot.Mar 7 2017, 9:00 PM

Change 341509 had a related patch set uploaded (by Jonas Kress (WMDE)):
[data-values/value-view] Use fulltext search in commons suggester

https://gerrit.wikimedia.org/r/341509

gerritbot added a project: Patch-For-Review.Mar 7 2017, 9:00 PM
• Jonas moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Mar 7 2017, 9:03 PM
WMDE-leszek removed the point value for this task.Mar 8 2017, 9:13 AM
gerritbot added a comment.Mar 8 2017, 6:15 PM

Change 341509 merged by jenkins-bot:
[data-values/value-view] Use fulltext search in commons suggester

https://gerrit.wikimedia.org/r/341509

• Jonas closed this task as Resolved.Mar 13 2017, 9:04 AM
• Jonas moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Mar 14 2017, 12:34 PM

Change 342610 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Jonas Kress (WMDE)):
[data-values/value-view] Change test to fulltext API search parameters

https://gerrit.wikimedia.org/r/342610

gerritbot added a comment.Mar 14 2017, 12:39 PM

Change 342610 merged by jenkins-bot:
[data-values/value-view] Change test to fulltext API search parameters

https://gerrit.wikimedia.org/r/342610

thiemowmde mentioned this in T159244: [Bug] Wrongly disabled save button while editing in value view experts.Mar 14 2017, 3:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL