Page MenuHomePhabricator
Create Task
Maniphest T159897

[Tech Debt] Encapsulate DonationInterface errors in SmashPig
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

We often see funky, homebrew error structures like,

gateway_common/gateway.adapter.php line 991

$this->transaction_response->setErrors( array(
    'internal-0000' => array(
        'debugInfo' => "Failed pre-process checks for transaction type $transaction.",
        'message' => $this->getErrorMapByCodeAndTranslate( 'internal-0000' ),
        'logLevel' => LogLevel::INFO
    )   
) );

Instead, use error objects from SmashPig.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/DonationInterfacemaster+679 -549Encapsulate errors
mediawiki/extensions/DonationInterfacemaster+1 K -1 KUpdate translated error messages for new scheme
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Mar 8 2017, 12:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2017, 12:51 AM
ggellerman triaged this task as Medium priority.Mar 21 2017, 9:21 PM
ggellerman added a project: FR-Ingenico.
ggellerman set the point value for this task to 4.
ggellerman moved this task from Triage to Q2 (Oct-Dec) 2020-2021 on the Fundraising-Backlog board.
Ejegg claimed this task.May 8 2017, 7:50 PM
Ejegg mentioned this in T130669: Push all translation up to the form layer.
Ejegg added a project: Fundraising Sprint Ivory Tower Defense Games.
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Ivory Tower Defense Games board.May 9 2017, 1:59 AM
gerritbot added a subscriber: gerritbot.May 10 2017, 12:04 AM

Change 344042 had a related patch set uploaded (by Ejegg; owner: Awight):
[mediawiki/extensions/DonationInterface@master] [WIP] Encapsulate errors

https://gerrit.wikimedia.org/r/344042

gerritbot added a project: Patch-For-Review.May 10 2017, 12:04 AM
gerritbot added a comment.May 10 2017, 1:46 AM

Change 352995 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] WIP Update error messages for new scheme

https://gerrit.wikimedia.org/r/352995

Ejegg moved this task from Doing to Review on the Fundraising Sprint Ivory Tower Defense Games board.May 10 2017, 7:04 PM
gerritbot added a comment.May 11 2017, 7:01 PM

Change 344042 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Encapsulate errors

https://gerrit.wikimedia.org/r/344042

gerritbot added a comment.May 11 2017, 7:01 PM

Change 352995 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Update translated error messages for new scheme

https://gerrit.wikimedia.org/r/352995

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 11 2017, 8:00 PM
mmodell removed a subscriber: awight.Jun 22 2017, 9:32 PM
DStrine moved this task from Q2 (Oct-Dec) 2020-2021 to Adam's old tasks on the Fundraising-Backlog board.May 6 2019, 8:33 PM
Aklapper closed this task as Resolved.Oct 14 2020, 8:44 PM
Aklapper removed a project: Patch-For-Review.

@Ejegg: Patches in Gerrit were merged three years ago. Assuming this task should be closed as resolved. If not, then please reopen. Thanks.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL