Page MenuHomePhabricator

Non-anchored popups don't align correctly
Closed, ResolvedPublic

Description

A popup button widget with a non-anchored popup has the wrong alignment (seems to have extra top margin and act as if it is anchored even though the anchor is hidden)

popup-widget-non-anchored-bug.png (147×347 px, 6 KB)

It would also be great if we could physically align/place the popup so that its right edge aligns with its trigger/anchor right edge.
Floatable element supports this with "horizontalPosition: end" - and mw.rcfilters.ui.FilterItemHighlightButton (where this popup is from) passes that in, but it seems to be overridden in the popup.

Event Timeline

Change 341731 had a related patch set uploaded (by Mooeypoo):
[mediawiki/core] RCFilters UI: Anchor the highlight popup

https://gerrit.wikimedia.org/r/341731

Change 341731 merged by jenkins-bot:
[mediawiki/core] RCFilters UI: Anchor the highlight popup

https://gerrit.wikimedia.org/r/341731

Change 355823 had a related patch set uploaded (by Catrope; owner: Catrope):
[oojs/ui@master] PopupWidget: Sensibly position anchor-less popups

https://gerrit.wikimedia.org/r/355823

Change 355824 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] RCFilters UI: Use backwards-aligned anchorless popups now that they work

https://gerrit.wikimedia.org/r/355824

Change 355823 merged by jenkins-bot:
[oojs/ui@master] PopupWidget: Sensibly position anchor-less popups

https://gerrit.wikimedia.org/r/355823

Change 355824 merged by jenkins-bot:
[mediawiki/core@master] RCFilters UI: Use backwards-aligned anchorless popups now that they work

https://gerrit.wikimedia.org/r/355824

Checked in betalabs - the popup is anchored and aligned (the issue with the misplaced checkmark is filed as T166874: [betalabs-Regression] The check mark for highlighted colors is not centered in color circles )

Screen Shot 2017-06-02 at 3.15.06 PM.png (338×674 px, 64 KB)