Page MenuHomePhabricator
Create Task
Maniphest T159911

Audit modules (2017)
Closed, ResolvedPublic
Actions

Description

T127328: Optimise critical rendering path | T202154: Audit modules 2018: Reduce registry overhead

Focus for 2017 is to audit what we load by default, and aim to load fewer modules by default.

For different definitions of "default". Environments:

  • MediaWiki core default.
  • MediaWiki-Vagrant default.
  • Production and Beta Cluster wikis.

And for each, looking at:

  • Simple wikitext page. (unrestricted, with parser output)
  • Special:Blankpage. (unrestricted, without parser output)
  • Special:Preferences, Special:UserLogin. (restricted, without parser output)

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+8 -14resourceloader: Fold legacy modules into base modules request
mediawiki/coremaster+11 -372Remove support for jquery.placeholder shim
mediawiki/extensions/NavigationTimingmaster+23 -10ext.navigationTiming: Only load eventlogging when needed
mediawiki/coremaster+13 -4Skin: Only load jquery.makeCollapsible if needed
mediawiki/coremaster+13 -5Skin: Preload jquery.tablesorter based on rough heuristics
Customize query in gerrit

Revisions and Commits

rMW MediaWiki
rMW0ac6076b4c08 resourceloader: Fold legacy modules into base modules request
rMWedd4985b7240 Remove support for jquery.placeholder shim
rMWac817da01464 mediawiki.widgets: Remove autoEllipsis() from TitleOptionWidget
rMW692bf795a991 Skin: Only load jquery.makeCollapsible if needed
rMW2fccd229d2e8 Skin: Preload jquery.tablesorter based on rough heuristics
rMWd7212e6cfb4e startup: Drop JavaScript support for browsers without DOM Level 2
rENTI extension-NavigationTiming
rENTI8957895a6e9e ext.navigationTiming: Only load eventlogging when needed

Related Objects
Search...

Event Timeline

Krinkle created this task.Mar 8 2017, 4:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2017, 4:39 AM
gerritbot added a subscriber: gerritbot.Mar 8 2017, 4:48 AM

Change 341750 had a related patch set uploaded (by Krinkle):
[mediawiki/core] Skin: Preload jquery.tablesorter based on rough heuristics

https://gerrit.wikimedia.org/r/341750

gerritbot added a project: Patch-For-Review.Mar 8 2017, 4:48 AM

Change 341751 had a related patch set uploaded (by Krinkle):
[mediawiki/core] Skin: Only load jquery.makeCollapsible if needed

https://gerrit.wikimedia.org/r/341751

Krinkle moved this task from Inbox to Assigned on the MediaWiki-ResourceLoader board.Mar 8 2017, 7:50 PM
Krinkle added a commit: rMWd7212e6cfb4e: startup: Drop JavaScript support for browsers without DOM Level 2.Mar 8 2017, 8:28 PM
gerritbot added a comment.Mar 8 2017, 8:38 PM

Change 341845 had a related patch set uploaded (by Krinkle):
[mediawiki/core] Remove support for jquery.placeholder shim

https://gerrit.wikimedia.org/r/341845

Krinkle added a subtask: T130632: mediawiki.toc module unnecessarily shipped in mobile views.Mar 8 2017, 8:42 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.Mar 8 2017, 9:42 PM
• Gilles moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Mar 9 2017, 9:46 PM
Krinkle triaged this task as High priority.Mar 9 2017, 9:59 PM
Krinkle added a parent task: T127328: Optimise critical rendering path.
gerritbot added a comment.Mar 14 2017, 6:58 PM

Change 342669 had a related patch set uploaded (by Krinkle):
[mediawiki/extensions/NavigationTiming] ext.navigationTiming: Only load eventlogging when needed

https://gerrit.wikimedia.org/r/342669

gerritbot added a comment.Mar 15 2017, 5:58 PM

Change 341750 merged by jenkins-bot:
[mediawiki/core] Skin: Preload jquery.tablesorter based on rough heuristics

https://gerrit.wikimedia.org/r/341750

gerritbot added a comment.Mar 15 2017, 5:58 PM

Change 341751 merged by jenkins-bot:
[mediawiki/core] Skin: Only load jquery.makeCollapsible if needed

https://gerrit.wikimedia.org/r/341751

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)).Mar 15 2017, 6:01 PM
Peter added a subscriber: Peter.Mar 15 2017, 6:33 PM
Krinkle added commits: rMW2fccd229d2e8: Skin: Preload jquery.tablesorter based on rough heuristics, rMW692bf795a991: Skin: Only load jquery.makeCollapsible if needed.Mar 15 2017, 7:07 PM
gerritbot added a comment.Mar 16 2017, 12:12 AM

Change 342669 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming] ext.navigationTiming: Only load eventlogging when needed

https://gerrit.wikimedia.org/r/342669

Krinkle added a commit: rENTI8957895a6e9e: ext.navigationTiming: Only load eventlogging when needed.Mar 16 2017, 3:47 AM
Krinkle created subtask T160804: Remove use of jquery.autoEllipsis in mw.widgets.TitleOptionWidget.Mar 17 2017, 11:39 PM
Krinkle closed subtask T160804: Remove use of jquery.autoEllipsis in mw.widgets.TitleOptionWidget as Resolved.Mar 18 2017, 2:51 AM
Krinkle added a commit: rMW717be846dd60: mediawiki.widgets: Remove autoEllipsis() from TitleOptionWidget.Mar 18 2017, 2:56 AM
Jdforrester-WMF reopened subtask T160804: Remove use of jquery.autoEllipsis in mw.widgets.TitleOptionWidget as Open.Mar 20 2017, 6:45 PM
Krinkle closed subtask T160804: Remove use of jquery.autoEllipsis in mw.widgets.TitleOptionWidget as Resolved.Mar 20 2017, 9:40 PM
Krinkle edited commits, added rMWac817da01464: mediawiki.widgets: Remove autoEllipsis() from TitleOptionWidget; removed rMW717be846dd60: mediawiki.widgets: Remove autoEllipsis() from TitleOptionWidget.
Krinkle renamed this task from Audit modules loaded by default (2017) to Audit modules (2017).Mar 21 2017, 2:49 AM
gerritbot added a comment.Apr 4 2017, 9:07 PM

Change 341845 merged by jenkins-bot:
[mediawiki/core@master] Remove support for jquery.placeholder shim

https://gerrit.wikimedia.org/r/341845

Jdforrester-WMF removed a project: Patch-For-Review.Apr 4 2017, 9:21 PM
Krinkle added a commit: rMWedd4985b7240: Remove support for jquery.placeholder shim.Apr 4 2017, 9:54 PM
Krinkle removed a project: MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)).
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)).Apr 4 2017, 10:00 PM
gerritbot added a comment.Apr 6 2017, 1:32 AM

Change 282505 had a related patch set uploaded (by Krinkle):
[mediawiki/core@master] [WIP] resourceloader: Merge legacy modules into base module request

https://gerrit.wikimedia.org/r/282505

gerritbot added a project: Patch-For-Review.Apr 6 2017, 1:32 AM
Krinkle added a subtask: T122755: Remove mediawiki.legacy.wikibits methods deprecated since before 1.18.Apr 6 2017, 9:17 PM
Krinkle mentioned this in T161490: Investigate Performance wins for Firefox Facebook page.Apr 7 2017, 9:41 PM
Krinkle closed subtask T122755: Remove mediawiki.legacy.wikibits methods deprecated since before 1.18 as Resolved.Apr 12 2017, 2:35 AM
gerritbot added a comment.Apr 13 2017, 1:45 AM

Change 282505 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Fold legacy modules into base modules request

https://gerrit.wikimedia.org/r/282505

ReleaseTaggerBot edited projects, added MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)); removed MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)).Apr 13 2017, 2:00 AM
Krinkle added a commit: rMW0ac6076b4c08: resourceloader: Fold legacy modules into base modules request.Apr 18 2017, 3:29 AM
Krinkle removed projects: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review.
Krinkle mentioned this in T131117: Refactor startup logic to bundle base modules and page modules into one unified request.Apr 27 2017, 9:15 PM
He7d3r added a subscriber: He7d3r.Apr 30 2017, 7:56 PM
Krinkle added a subtask: T164148: Load module 'mediawiki.action.view.postEdit' only when needed.May 1 2017, 10:59 PM
Krinkle mentioned this in T127328: Optimise critical rendering path.May 5 2017, 10:38 PM
Nirmos added a subscriber: Nirmos.May 10 2017, 10:52 AM

Should T145997 (now merged into T63007) be looked at in conjunction with this? A large proportion of gadgets are only relevant in a certain namespace, or during a certain action, but are loaded everywhere anyway. I can imagine that quite a lot of time and bytes could be saved by allowing gadget authors to set constraints on when and where gadgets should load.

Krinkle closed subtask T164148: Load module 'mediawiki.action.view.postEdit' only when needed as Resolved.May 11 2017, 10:09 PM
• Jdlrobson closed subtask T130632: mediawiki.toc module unnecessarily shipped in mobile views as Resolved.May 24 2017, 1:04 PM
He7d3r added a comment.May 25 2017, 1:32 PM

Some time ago a few gadgets were split into a pair of modules (a 'loader' and a [hidden] 'core' part), so that only the loader was loaded by default, to check if the core was also needed in a given situation. Here are some examples which are organized like this:
https://en.wikipedia.org/wiki/MediaWiki:Gadget-refToolbar.js
https://en.wikipedia.org/wiki/MediaWiki:Gadget-geonotice.js
https://en.wikipedia.org/wiki/MediaWiki:Gadget-watchlist-notice.js
https://en.wikipedia.org/wiki/MediaWiki:Gadget-charinsert.js
https://en.wikipedia.org/wiki/MediaWiki:Gadget-extra-toolbar-buttons.js

See also

Nirmos added a comment.May 25 2017, 9:34 PM

Right, that solves the problem of loading a large script that is not relevant everywhere, but that also bypasses the minification. I was thinking we could have the best of two worlds, by moving conditions like

if ( mw.config.get( 'wgCanonicalSpecialPageName' ) === 'Watchlist' ) {
	//...
}

from the script to MediaWiki:Gadgets-definition.

Krinkle added a comment.EditedMay 26 2017, 10:32 AM
In T159911#3293410, @Nirmos wrote:

Right, that solves the problem of loading a large script that is not relevant everywhere, but that also bypasses the minification.

No, it does not. It registers two modules ("extra-toolbar-buttons", "extra-toolbar-buttons-core") both of which are a Gadget module, both are loaded through mw.loader from load.php with combination, minification and compression. It just means that instead of loading the module by default on every page, the second module is triggered by the first one. This is not importScript from action=raw. mw.loader.load() supports everything it normally does: multiple files, stylesheets, dependencies etc.

Nirmos added a comment.May 26 2017, 10:56 AM

Ah, ok. I thought He7d3r linked to something like https://sv.wikipedia.org/wiki/MediaWiki:Gadget-teahouse.js or https://sv.wikipedia.org/wiki/MediaWiki:Gadget-Geonotice.js which solves one problem and creates another.

He7d3r added a comment.May 27 2017, 12:28 PM
In T159911#3294262, @Nirmos wrote:

Ah, ok. I thought He7d3r linked to something like https://sv.wikipedia.org/wiki/MediaWiki:Gadget-teahouse.js or https://sv.wikipedia.org/wiki/MediaWiki:Gadget-Geonotice.js which solves one problem and creates another.

That is true in the case of refToolbar, which has a few importScript calls. The others use something like mw.loader.load( 'ext.gadget.********' );

Fomafix reopened subtask T164148: Load module 'mediawiki.action.view.postEdit' only when needed as Open.Jun 8 2017, 6:03 PM
Fomafix closed subtask T164148: Load module 'mediawiki.action.view.postEdit' only when needed as Resolved.Jun 9 2017, 6:16 AM
Krinkle moved this task from Doing (old) to To-do: Goals prioritized current Quarter on the Performance-Team board.Jun 14 2017, 7:34 PM
Krinkle closed this task as Resolved.Jun 27 2017, 9:05 PM
Krinkle created subtask T176159: Skip mw.loader.implement() boiler plate for no-op user.options.Sep 18 2017, 5:48 PM
Jdforrester-WMF closed subtask T176159: Skip mw.loader.implement() boiler plate for no-op user.options as Resolved.Sep 25 2017, 3:29 PM
Krinkle reopened subtask T164148: Load module 'mediawiki.action.view.postEdit' only when needed as Open.Oct 5 2017, 9:04 PM
Deskana closed subtask T164148: Load module 'mediawiki.action.view.postEdit' only when needed as Resolved.Oct 10 2017, 11:54 AM
Krinkle added a subtask: T165112: Kill of most/all the WikiEditor RL modules.Nov 22 2017, 8:28 PM
Jdforrester-WMF closed subtask T165112: Kill of most/all the WikiEditor RL modules as Resolved.Jan 4 2018, 4:11 PM
Krinkle mentioned this in T202154: Audit modules 2018: Reduce registry overhead.Aug 17 2018, 6:17 PM
Krinkle updated the task description. (Show Details)Aug 17 2018, 6:29 PM
Krinkle removed a project: MW-1.29-release-notes.Mar 5 2019, 4:24 PM
Krinkle updated the task description. (Show Details)
Krinkle updated the task description. (Show Details)Aug 6 2019, 7:13 PM
Krinkle updated the task description. (Show Details)Sep 19 2019, 6:20 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL