Page MenuHomePhabricator

Ensure Credits file is updated for Maps
Closed, ResolvedPublic

Description

We've had a handful of volunteer PRs in this version so lets make sure we add them to the credits.

Additionally we need to add a link to the Apple Maps rights page. I suggest that under "Libraries used" we add a new section "Maps used" with the text "Apple Maps" as a link to this page: http://gspe21.ls.apple.com/html/attribution-56.html

If there is a programmatic way to get to the "current attribution" page for maps (rather than hard coding the url) that would be preferred, so we don't have to monitor and update this link as they revise their attribution page.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
JMinor renamed this task from Ensure Credits file is updated to Ensure Credits file is updated for Maps.Apr 20 2017, 6:52 PM

@JMinor

Hey I was taking a peek at this ticket and noticed "Settings > About the app > Libraries used > Complete list" looks a bit different than I remembered if you scroll to bottom:

Screen Shot 2017-05-04 at 6.43.18 PM.png (862×1,468 px, 188 KB)

Assuming that's a regression?

Testing criteria:

  • Tap "Settings > About the app > Complete list" (of Libraries used)
  • Ensure there's an entry for "Maps"
  • Ensure other entries seem to load as well (the under-the-hood code which handles these has been changed)

Tap image for animation:

maps.mov.gif (400×720 px, 2 MB)

ABorbaWMF subscribed.

Tested on an iPhone 7+ with iOS 10.3 and an iPhone 5s with iOS 10.2 on Beta App 5.5.0 (1134)

Fixed