| Etonkovidova | |
| Mar 8 2017, 11:26 PM |
| F11127753: Screen Shot 2017-12-01 at 11.44.05 AM.png | |
| Dec 1 2017, 7:55 PM |
| F11127750: Screen Shot 2017-12-01 at 11.54.08 AM.png | |
| Dec 1 2017, 7:55 PM |
| F6347829: Screen Shot 2017-03-08 at 11.14.01 AM.png | |
| Mar 8 2017, 11:26 PM |
| F6347816: Screen Shot 2017-03-08 at 11.14.16 AM.png | |
| Mar 8 2017, 11:26 PM |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T160001 [minor] RC filters - the highlight color selection box is not fully displayed at the bottom of viewport | |||
| Resolved | matmarex | T158934 Automatically change popup direction if there is no space | |||
| Resolved | matmarex | T178892 ClippableElement only clips with bottom and right edges (but not with top and left edges) | |||
| Resolved | matmarex | T106095 Fixed-position headers/footers obscure last elements of OOUI dropdowns |
Normally max-height: 70vh ensures that this can't happen, but only because the "Active filters" widget is scrolled to the top when the filter list opens. When there are no results, the page can't be scrolled, so this doesn't happen, and the max-height rule does not prevent the popup from extending to the bottom of the screen.
One way to address this would be to fix T158934: Automatically change popup direction if there is no space, which would make the popup automatically pop up instead of down when there's not enough space below. We could also look into having the popup keep away from the edge even in these unscrollable situations, but that would probably require either making ClippableElement's 7-pixel buffer configurable, or a dirty hack like making the footer overflow: visible; and adding a spacer with height: 30vh to the bottom of it.
Now that the patch for T158934: Automatically change popup direction if there is no space is approved, I suggest we wait until OOjs UI v0.24.3 is used on MediaWiki and move this ticket to QA for recheck.
OOjs UI is updated to v0.24.3, and the popup now displays above the button when there is no room below.
Moving to QA for @Etonkovidova to check.
Checked in betalabs. Now we have some extra space at the end of the drop-down filter menu - for Advanced filters - it's a little bit tricky to check if the fix does work.
I checked it by removing div for Advanced filters and the feedback:
When only the feedback is present:
