Implement UI changes for diff view to make moved paragraphs more visible.
Description
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | DannyH | T121469 Improve diff compare screen | |||
Resolved | thiemowmde | T139603 Show text changes when moving text chunks (#2) | |||
Resolved | None | T146781 Show changes in moved text chunks (C++) | |||
Resolved | • jkroll | T160077 UI changes for showing changes in moved text chunks | |||
Resolved | WMDE-Fisch | T166882 Add tooltip to elements indicating a moved paragraph | |||
Resolved | • jkroll | T180602 Add placeholder for title tags to the moved indicators |
Event Timeline
Taking Tim Starling's feedback on Gerrit into account, I've inserted named anchors in the diff output for moved paragraphs. The + and - symbols are replaced with "left shift" (<<) and "right shift" (>>) symbols. Hyperlinks allow to move between source and destination paragraphs. This is a good solution because
- it shows which paragraphs were moved, even if they weren't changed
- it's plain text, so it can be searched for in the browser
- it doesn't require JavaScript or visual changes which have to be adjusted to each Skin, such as different background colors for moved blocks
The code is straightforward and doesn't have performance implications, so it doesn't require a separate patch set.
Example links:
https://wmde-wikidiff2-patched.wmflabs.org/core/index.php?title=Red_imported_fire_ant&diff=24&oldid=23
https://wmde-wikidiff2-patched.wmflabs.org/core/index.php?title=Red_imported_fire_ant&diff=25&oldid=24
https://wmde-wikidiff2-patched.wmflabs.org/core/index.php?title=Red_imported_fire_ant&diff=26&oldid=25
Feedback welcome.
First, a huge thank you for working on showing moves in diff! YEAY!
This is minor, but the example links use a curved arrow to mark moved paragraphs... that arrow is a bit strange and confusing at first sight. I would suggest replacing it with up and down arrows, pointing toward the copy in the other column.