Page MenuHomePhabricator

UI changes for showing changes in moved text chunks
Closed, ResolvedPublic


Implement UI changes for diff view to make moved paragraphs more visible.

Event Timeline

Taking Tim Starling's feedback on Gerrit into account, I've inserted named anchors in the diff output for moved paragraphs. The + and - symbols are replaced with "left shift" (<<) and "right shift" (>>) symbols. Hyperlinks allow to move between source and destination paragraphs. This is a good solution because

  • it shows which paragraphs were moved, even if they weren't changed
  • it's plain text, so it can be searched for in the browser
  • it doesn't require JavaScript or visual changes which have to be adjusted to each Skin, such as different background colors for moved blocks

The code is straightforward and doesn't have performance implications, so it doesn't require a separate patch set.

Example links:

Feedback welcome.

First, a huge thank you for working on showing moves in diff! YEAY!

This is minor, but the example links use a curved arrow to mark moved paragraphs... that arrow is a bit strange and confusing at first sight. I would suggest replacing it with up and down arrows, pointing toward the copy in the other column.

@Alsee thank you for the feedback! What's there right now is very low level and we have a plan of changing the current layout to something more user-friendly which we are tracking in T140340.