Page MenuHomePhabricator

`$wgAllowCategorizedRecentChanges = true` and using the "Limit to categories" input on Special:RecentChanges no longer works (PHP exceptions)
Closed, DuplicatePublic

Description

There exists a config option $wgAllowCategorizedRecentChanges = true that when set, allows users to limit Special:RecentChanges to specific categories.

But on current master, actually using the "Limit to categories" input on Special:RecentChanges results in an uncaught PHP exception:

[236782f10849c858506e6e62] /w/index.php?namespace=&categories=asdf&tagfilter=&title=Specjalna%3AOstatnie+zmiany Error from line 401 of /var/www/html/w/includes/specialpage/ChangesListSpecialPage.php: Call to a member function numRows() on array

Backtrace:

#0 /var/www/html/w/includes/specialpage/ChangesListSpecialPage.php(79): ChangesListSpecialPage->webOutput(array, FormOptions)
#1 /var/www/html/w/includes/specials/SpecialRecentchanges.php(67): ChangesListSpecialPage->execute(NULL)
#2 /var/www/html/w/includes/specialpage/SpecialPage.php(522): SpecialRecentChanges->execute(NULL)
#3 /var/www/html/w/includes/specialpage/SpecialPageFactory.php(576): SpecialPage->run(NULL)
#4 /var/www/html/w/includes/MediaWiki.php(285): SpecialPageFactory::executePath(Title, RequestContext)
#5 /var/www/html/w/includes/MediaWiki.php(860): MediaWiki->performRequest()
#6 /var/www/html/w/includes/MediaWiki.php(521): MediaWiki->main()
#7 /var/www/html/w/index.php(43): MediaWiki->run()
#8 {main}

I suspect this is caused by some of the changes to the filters for ERI. (But the issue occurs even with that not enabled. So maybe not.)

$wgAllowCategorizedRecentChanges = true is a very unloved option. I think actually intentionally removing it could be a solution to this task, if it's difficult to support now. But right now it exists and is broken.