Page MenuHomePhabricator

Clean up mess with Kartotherian and Tilerator configs
Closed, ResolvedPublic

Description

Currently, both have a pile of configuration and source files in their directories, which makes configuration management (and just looking up which of them if being used where) a pain. Proposal:

  • Move everything configuration-related into a subdirectory, e.g. config-examples.
  • Make these examples truly examplish, so that they might be used by third parties or developers to better understand how to configure the software.
  • Keep WMF configuration in WMF deployment repositories.
  • Make Kartotherian and Tilerator use the same sources config.

Event Timeline

MaxSem triaged this task as High priority.Mar 10 2017, 11:59 PM

Sounds great. Source loader can consume multiple source files, so tilerator could use production file plus some more sources

Change 351872 had a related patch set uploaded (by Gehel; owner: Gehel):
[operations/puppet@production] maps - align configuration for all maps clusters

https://gerrit.wikimedia.org/r/351872

Change 385394 had a related patch set uploaded (by Gehel; owner: Gehel):
[operations/puppet@production] maps: move kartotherian and tilerator sources to puppet

https://gerrit.wikimedia.org/r/385394

Change 385395 had a related patch set uploaded (by Gehel; owner: Gehel):
[operations/puppet@production] maps: use puppet generated configs for sources.

https://gerrit.wikimedia.org/r/385395

Change 385394 merged by Gehel:
[operations/puppet@production] maps: move kartotherian and tilerator sources to puppet

https://gerrit.wikimedia.org/r/385394

Change 385395 merged by Gehel:
[operations/puppet@production] maps: use puppet generated configs for sources.

https://gerrit.wikimedia.org/r/385395

Mentioned in SAL (#wikimedia-operations) [2017-10-23T10:08:52Z] <gehel> restart tilerator / karthotherian for config change on all maps clusters - T160215

Config of sources is now under puppet control for tilerator / kartotherian. It might make sense to remove the sources.prod*yaml files from kartotherian / tilerator repos and just keep the examples.

@Yurik does it make sense to you? I'm sending a PR, we'll see what you say about it :)

PR opened to upstream. The following still needs to be done:

  • Move everything configuration-related into a subdirectory, e.g. config-examples.
  • Make these examples truly examplish, so that they might be used by third parties or developers to better understand how to configure the software.

This should probably be done by upstream. I'm not sure if we want to move this ticket to Github issue, or to keep it here and assign @Yurik to it. In any case, work from the maps-team is done.