| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove unused CSS & templates from www.wikipedia.org portal | wikimedia/portals | master | +5 -585 |
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • debt | T140159 [epic] Wikipedia.org Portal: automating updates for the portal | |||
| Resolved | • debt | T177340 [epic] Wikipedia.org portal technical debt: clean up code before automating | |||
| Resolved | • debt | T160217 Clean up portals CSS | |||
| Resolved | • JGirault | T160131 Re-arrange css code | |||
| Resolved | • JGirault | T160219 Replace colors with CSS variables | |||
| Resolved | • debt | T160222 Remove unused CSS classes | |||
| Resolved | • JGirault | T160474 Convert inconsistent font sizes, margins, paddings units... to rem unit | |||
| Declined | None | T162717 Improve print style on portal |
Event Timeline
Comment Actions
Moving this to the backlog to work on when we begin automating the portal update code.
Comment Actions
Change 383545 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[wikimedia/portals@master] Removing unused CSS from www.wikipedia.org portal
Comment Actions
For comparicon: The document on wikipedia.org before the optimisation is 85.7 KB with all styles inlined.
Comment Actions
Change 383545 merged by jenkins-bot:
[wikimedia/portals@master] Remove unused CSS & templates from www.wikipedia.org portal
Comment Actions
@Volker_E good point. I ran a build of the portal with the above patch, and on my machine index.html clocks in at about 75kb
Before this patch, index.html clocks in at about 85kb (like you mentioned)
Comment Actions
performance changes will be more accurately observed on our dashboard https://grafana.wikimedia.org/dashboard/db/webpagetest-portals?refresh=1m&orgId=1