There are some parts that have been removed (related to old language search, old <button> etc), we need to remove the CSS too.
Note: we may also remove the language-search.handlebars template.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | debt | T140159 [epic] Wikipedia.org Portal: automating updates for the portal | |||
| Resolved | debt | T177340 [epic] Wikipedia.org portal technical debt: clean up code before automating | |||
| Resolved | debt | T160217 Clean up portals CSS | |||
| Resolved | • JGirault | T160131 Re-arrange css code | |||
| Resolved | • JGirault | T160219 Replace colors with CSS variables | |||
| Resolved | debt | T160222 Remove unused CSS classes | |||
| Resolved | • JGirault | T160474 Convert inconsistent font sizes, margins, paddings units... to rem unit | |||
| Declined | None | T162717 Improve print style on portal |
Event Timeline
Comment Actions
Change 342289 had a related patch set uploaded (by JGirault):
[wikimedia/portals] Remove pieces of CSS not used on wikipedia.org
Comment Actions
I think there's a lot more CSS that can be removed here.
There's a nifty chrome devtools feature that highlights what it thinks is unused CSS. These results need manual review because it picks up things like the 'no-js' and typeahead styles as unused, but I think it provides a good starting point.
Comment Actions
@Jdrewniak it's true, I know there are more, this is a long and intense and cautious work in order to clean our CSS.
I'd rather do it iteratively. Keep cleaning stuff as we find it. Merge patches if they are good to be merged. And keep cleaning. There is some CSS classes with pure-buttons that I'd like to follow with a discussion with @Volker_E because some of it could be made available to the community, via the new style guide for instance.
Comment Actions
Change 342289 merged by jenkins-bot:
[wikimedia/portals@master] Remove pieces of CSS not used on wikipedia.org
Comment Actions
Moving this to the backlog to work on when we begin automating the portal update code.
Comment Actions
Change 383545 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[wikimedia/portals@master] Removing unused CSS from www.wikipedia.org portal
Comment Actions
Change 383545 merged by jenkins-bot:
[wikimedia/portals@master] Remove unused CSS & templates from www.wikipedia.org portal
This comment was removed by Jdrewniak.