Page MenuHomePhabricator

Horizontal page previews have double arrows when appearing above the link on Edge & IE
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to Reproduce:

  1. Navigate to https://en.wikipedia.beta.wmflabs.org/wiki/Dog
  2. Scroll down the page until the 'fox' link is visible at the bottom of the screen.
  3. Hover over 'fox'

Expected Result:
The page preview appears above the link with the arrow pointing towards the link.

Actual Result:
The page preview appears above the link with arrows at the top and bottom of the preview

Previews-IE-Double-Arrow.png (768ร—1 px, 348 KB)

Browsers:
Microsoft Edge, IE11, IE10, IE9

Does not happen on:
Chrome, Firefox, Opera

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptMar 11 2017, 5:05 AM
phuedx added a subscriber: phuedx.

This might be a regression. This'll need a little more analysis.

My (informed) guess is that this isn't a regression. The issue seems to be caused by [setting the clip-path attribute to '' in Renderer#layoutPreview](https://github.com/wikimedia/mediawiki-extensions-Popups/blob/master/src/renderer.js#L624-L626), which IE appears to ignore and uses the previously set default value of mwe-popups-mask.

Change 342437 had a related patch set uploaded (by Phuedx):
[mediawiki/extensions/Popups] renderer: Remove attributes don't set them to ''

https://gerrit.wikimedia.org/r/342437

Change 342437 merged by jenkins-bot:
[mediawiki/extensions/Popups] renderer: Remove attributes don't set them to ''

https://gerrit.wikimedia.org/r/342437

This is fixed now as on Edge

T160237 on Edge.jpg (731ร—1 px, 308 KB)
and IE11
T160237 on IE11.jpg (889ร—1 px, 400 KB)
only the arrow pointing towards the link is shown in the page preview window.

Per @ABorbaWMF 's request last week I will leave this card in Needs QA for now so that related test cases can be added to the Hovercards Testing regression in Google Drive.

This bug appears to be fixed. Tested on:

Windows 10 - IE11 - Edge 14
Windows 8.1 - IE10
Windows 7 - IE9

looks good to me as well!