Page MenuHomePhabricator

Pageviews-num-pageviews works incorrectly in Hebrew
Closed, ResolvedPublic

Description

If I read the page https://tools.wmflabs.org/pageviews/?project=he.wikipedia.org&platform=all-access&agent=user&range=latest-20&pages=ASCII in English, I see "1,062 pageviews" under the chart, which makes sense.

If I read the same page with Hebrew UI, I see "צפייה אחת בדף", which means "one pageview". The singular part of the {{PLURAL}} clause in the translation is displayed, and this is wrong.

Noticed by User:Uziel302 and reported on my user talk page at translatewiki.net.

Event Timeline

MusikAnimal claimed this task.
MusikAnimal moved this task from Backlog to Done on the Tool-Pageviews board.
MusikAnimal subscribed.

Wow... I've only just now figured out that I needed to source CLDRPluralRuleParser.js!!! I had no idea! I assumed I should use everything in https://github.com/wikimedia/jquery.i18n/tree/master/src and nothing more. This fixes both issue 125 and 105. Goodness... I just can't believe I've gone this long with PLURAL not working for many languages. Sorry I didn't figure this out sooner. I will make a pull request to improve the jquery.i18n README, and explicitly list what needs to be sourced.

Anyway I've deployed the plural parser along with TONS of other RTL fixes :) Thanks for the report.