Page MenuHomePhabricator

Replace job translatewiki-shelllint and have its functionality invoked from composer
Closed, ResolvedPublic

Description

The Jenkins job translatewiki-shelllint just does:

find bin -maxdepth 1 -type f -print0 | xargs -t -n1 -0 bash -n

The repo already has a job that runs composer test so I guess we can migrate the behavior inside composer as a script that is local to the repo instead of hardcoded in a Jenkins job. That will let us remove the job.

Event Timeline

hashar created this task.Mar 14 2017, 8:54 AM

Change 342590 had a related patch set uploaded (by Hashar):
[translatewiki] lint bash script from composer test command

https://gerrit.wikimedia.org/r/342590

Change 342597 had a related patch set uploaded (by Hashar):
[integration/config] Remove translatewiki-shelllint

https://gerrit.wikimedia.org/r/342597

Change 342597 merged by jenkins-bot:
[integration/config] Remove translatewiki-shelllint

https://gerrit.wikimedia.org/r/342597

The job is no more in CI. Pending https://gerrit.wikimedia.org/r/#/c/342590/ which replaces the behavior by a PHP script invoked from composer test.

Change 342590 merged by jenkins-bot:
[translatewiki] lint bash script from composer test command

https://gerrit.wikimedia.org/r/342590

hashar closed this task as Resolved.Mar 14 2017, 3:37 PM
hashar added a subscriber: Nikerabbit.

Merged by @Nikerabbit :-}