ItemClaimFilter only assumes ItemPage
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matej_suchanek
	Mar 14 2017, 9:48 AM

Description

Currently, there is this code:

if not isinstance(page, pywikibot.ItemPage):
    pywikibot.output(u'%s is not an ItemPage. Skipping.' % page)
    return False

There are more (atm at least one) entity types which support claims. It may be renamed (and redirected) to EntityClaimFilter, WikibasePageClaimFilter or just ClaimFilter.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Handle non-items in ItemClaimFilterPageGenerator	pywikibot/core	master	+5 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T160395 Make Wikibase entity related code more flexible (tracking)
		Resolved		matej_suchanek	T160396 ItemClaimFilter only assumes ItemPage

Event Timeline

matej_suchanek created this task.Mar 14 2017, 9:48 AM

Please expand this task

matej_suchanek updated the task description. (Show Details)May 20 2017, 7:54 AM

Change 366206 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[pywikibot/core@master] Handle non-items in ItemClaimFilterPageGenerator

https://gerrit.wikimedia.org/r/366206

gerritbot added a project: Patch-For-Review.Jul 19 2017, 8:33 AM

matej_suchanek claimed this task.Jul 19 2017, 8:33 AM

Change 366206 merged by jenkins-bot:
[pywikibot/core@master] Handle non-items in ItemClaimFilterPageGenerator

https://gerrit.wikimedia.org/r/366206

matej_suchanek closed this task as Resolved.Sep 5 2017, 3:47 PM

matej_suchanek removed a project: Patch-For-Review.