PreloadingItemGenerator and DataSite.preloaditempages don't work with properties
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matej_suchanek
	Mar 14 2017, 9:54 AM

Description

>>> import pywikibot
>>> from pywikibot import pagegenerators
>>> repo = pywikibot.Site('wikidata', 'wikidata')
>>> gen = iter([pywikibot.PropertyPage(repo, 'P6')])
>>> list(pagegenerators.PreloadingItemGenerator(gen))
pywikibot.exceptions.InvalidTitle: 'P6' is not a valid item page title

There are other types of entites which we can iterate over, so it would be nice to have other types of entities supported.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	[IMPR] Make preloading generators work with arbitrary entity types	pywikibot/core	master	+47 -32

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T160395 Make Wikibase entity related code more flexible (tracking)
		Resolved		Xqt	T160397 PreloadingItemGenerator and DataSite.preloaditempages don't work with properties

Event Timeline

matej_suchanek created this task.Mar 14 2017, 9:54 AM

matej_suchanek mentioned this in T160399: WikibaseItemGenerator should be made more dynamic.Mar 14 2017, 10:10 AM

Properties are not items so I would say that this works as designed?

Yes, but we may need to reuse it for other types of entities (like properties).

Change 342588 had a related patch set (by Matěj Suchánek) published:
[pywikibot/core@master] [IMPR] Make preloading generators work with arbitrary entity types

https://gerrit.wikimedia.org/r/342588

gerritbot added a project: Patch-For-Review.Jan 24 2018, 8:01 PM

Xqt closed this task as Resolved.Feb 23 2018, 5:06 PM

Xqt claimed this task.

Xqt triaged this task as High priority.

Change 342588 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Make preloading generators work with arbitrary entity types