Page MenuHomePhabricator
Create Task
Maniphest T160439

Rename SerializerFactory to BaseModelSerializerFactory
Closed, ResolvedPublic
Actions

Description

The SerializerFactory class is not a generic factory for serializers. It only supports the base model. In particular, it does not support custom entity types. BaseModelSerializerFactory would be a more descriptive name, that would avoid the confusion that led to T160426.

The same applies for DeserializerFactory.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Better names for WikibaseRepo/Client (de)serializer factory methodsmediawiki/extensions/WikibaseQualityConstraintsmaster+14 -14
Better names for WikibaseRepo/Client (de)serializer factory methodsmediawiki/extensions/Wikibasemaster+43 -40
Better names for WikibaseRepo/Client (de)serializer factory methodsmediawiki/extensions/Wikibasemaster+37 -33
Rename getEntitySerializer to getAllTypesEntitySerializermediawiki/extensions/Wikibasemaster+15 -15
Rename getExternalFormatDeserializerFactory to getBaseDataModelDeserializerFactorymediawiki/extensions/Wikibasemaster+14 -14
Rename getExternalFormatEntityDeserializer to getAllTypesEntityDeserializermediawiki/extensions/Wikibasemaster+5 -5
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenFeatureNoneT13996 A way to select which parts of Wiktionary articles to show
 OpenFeatureNoneT13998 A way to show only those languages on Wiktionary that the user is interested in
 OpenFeatureNoneT14213 Following a link to a language entry in Wiktionary should display only that entry
 OpenFeatureNoneT38881 Wiktionary needs usable API
 OpenNoneT31229 Extension to provide access via the dict protocol
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 DuplicateNoneT66288 basic support for structured data on mediawiki files
 InvalidLydia_PintscherT76012 make use of new entity type for multimedia / structured data of media files
 ResolvedLydia_PintscherT146637 Wikidata 2016 Q4 goals
 ResolvedLydia_PintscherT150179 Wikidata 2017 Q1 goals
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 ResolvedLydia_PintscherT986 Use structured data on Wiktionary
 ResolvedLydia_PintscherT988 Phase 1: Represent Wiktionary lexicon using structured data
 ResolvedLydia_PintscherT987 [Story] Phase 0: Automate interwiki language links for Wiktionary
 ResolvedAddshoreT145412 Review & work on Cognate extension
 ResolvedAddshoreT146877 Purge pages on other wikis when cognate entry is added or removed.
 ResolvedAddshoreT146879 Normalize titles to keys
 ResolvedLydia_PintscherT147656 Overwriting and suppressing interwiki links also for Wiktionary?
 ResolvedAddshoreT150182 Deploy Cognate extension to production
 ResolvedAddshoreT149688 Enable overriding Cognate interwiki links using wikitext
 ResolvedjcrespoT148988 Cognate DB review
 ResolvedAddshoreT150183 Deploy InterwikiSorting extension to production
 ResolvedAddshoreT155995 Deploy InterwikiSorting extension to beta
 ResolvedBawolffT149083 Security review for InterwikiSorting Extension
 ResolvedAddshoreT158628 Create beta hewiktionary for testing InterwikiSorting & Cognate
 ResolvedAddshoreT149892 Cognate links should probably not be recorded for page redirects
 ResolvedAddshoreT146991 Add script to populate Cognate titles db table
 ResolvedAddshoreT146878 Cognate Sorting of language links.
 ResolvedAddshoreT150437 Cognate incorrectly links to normalized title instead of actual title
 DuplicateWMDE-leszekT150514 Use the original form of the page title in a link to a particular site
 ResolvedWMDE-leszekT150517 Set $wgCapitalLinks = false on Cognate test system
 ResolvedAddshoreT156241 Deploy Cognate extension to beta
 ResolvedAddshoreT149082 Security review for Cognate Extension
 ResolvedAddshoreT150404 Use hashes to identify matching page titles in Cognate DB schema
 ResolvedAddshoreT156238 Use HTMLCacheUpdateJob in Cognate extension
 ResolvedAddshoreT156239 Cognate - Make PageContentSaveComplete check for redirect state changes & only act when they (or page creation) happens
 ResolvedAddshoreT156240 Stop writes on hash conflicts & log that they occour
 ResolvedAddshoreT160503 Wikimedia\Assert\ParameterTypeException from line 89 of /srv/mediawiki-staging/php-master/vendor/wikimedia/assert/src/Assert.php: Bad value for parameter $namespace: must be a integer
 ResolvedMarosteguiT162252 Create SQL database and Tables for Cognate extension to be used on Wiktionaries
 ResolvedAddshoreT162253 Deploy InterwikiSorting extension to wiktionaries
 ResolvedAddshoreT162926 Set wgInterwikiSortingSort for Wiktionarys
 DeclinedNoneT162882 Cognate for Rhyme namespace?
 ResolvedLydia_PintscherT146662 [Story] new entity type for Lexemes (baseline)
 ResolvedLydia_PintscherT148139 Implement a base version of the Lexeme Entity type
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 OpenNoneT67626 [Epic] Support for queries on-wiki (automated list generation)
 ResolvedAddshoreT76019 [Story] Support new types of Entities in Wikibase Client
 ResolvedthiemowmdeT135650 [Task] Migrate PropertySuggester away from assuming all entities are numeric
 ResolvedAddshoreT75496 [Epic] Support new types of Entities in Wikibase Repository
 InvalidNoneT160436 Remove SerializerFactory::newEntitySerializer
 ResolvedthiemowmdeT160439 Rename SerializerFactory to BaseModelSerializerFactory

Event Timeline

daniel created this task.Mar 14 2017, 5:30 PM
gerritbot subscribed.Mar 14 2017, 5:33 PM

Change 338749 had a related patch set uploaded (by Daniel Kinzler; owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase] Better names for WikibaseRepo/Client (de)serializer factory methods

https://gerrit.wikimedia.org/r/338749

gerritbot added a project: Patch-For-Review.Mar 14 2017, 5:33 PM
thiemowmde mentioned this in T160436: Remove SerializerFactory::newEntitySerializer.Mar 15 2017, 2:33 PM
thiemowmde edited projects, added Wikibase-DataModel-Serialization; removed Patch-For-Review.Mar 15 2017, 2:35 PM

See T160436#3102219 for a longer comment on this whole topic. Personally I'm fine with both BaseDataModelSerializerFactory and BaseModelSerializerFactory.

thiemowmde mentioned this in T157596: [Task] Make DataModel Serialization SerializerFactory support custom entity types.Mar 15 2017, 5:57 PM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Mar 23 2017, 2:14 PM
gerritbot added a comment.May 2 2017, 9:05 AM

Change 351263 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Rename getExternalFormatEntityDeserializer to getAllTypesEntityDeserializer

https://gerrit.wikimedia.org/r/351263

gerritbot added a project: Patch-For-Review.May 2 2017, 9:05 AM

Change 351264 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Rename getExternalFormatDeserializerFactory to getBaseDataModelDeserializerFactory

https://gerrit.wikimedia.org/r/351264

gerritbot added a comment.May 2 2017, 9:54 AM

Change 351263 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Rename getExternalFormatEntityDeserializer to getAllTypesEntityDeserializer

https://gerrit.wikimedia.org/r/351263

gerritbot added a comment.May 2 2017, 9:55 AM

Change 351264 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Rename getExternalFormatDeserializerFactory to getBaseDataModelDeserializerFactory

https://gerrit.wikimedia.org/r/351264

gerritbot added a comment.May 2 2017, 1:29 PM

Change 351310 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Rename getEntitySerializer to getAllTypesEntitySerializer

https://gerrit.wikimedia.org/r/351310

gerritbot added a comment.May 4 2017, 5:18 PM

Change 351310 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Rename getEntitySerializer to getAllTypesEntitySerializer

https://gerrit.wikimedia.org/r/351310

gerritbot added a comment.Jun 12 2017, 12:44 PM

Change 358356 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Better names for WikibaseRepo/Client (de)serializer factory methods

https://gerrit.wikimedia.org/r/358356

gerritbot added a comment.Jun 12 2017, 12:45 PM

Change 338749 abandoned by Thiemo Mättig (WMDE):
Better names for WikibaseRepo/Client (de)serializer factory methods

Reason:
Resubmitted as Idd4f43a.

https://gerrit.wikimedia.org/r/338749

gerritbot added a comment.Jun 12 2017, 12:45 PM

Change 358357 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Better names for WikibaseRepo/Client (de)serializer factory methods

https://gerrit.wikimedia.org/r/358357

gerritbot added a comment.Jun 27 2017, 11:23 AM

Change 358356 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Better names for WikibaseRepo/Client (de)serializer factory methods

https://gerrit.wikimedia.org/r/358356

gerritbot added a comment.Jun 27 2017, 11:57 AM

Change 358357 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Better names for WikibaseRepo/Client (de)serializer factory methods

https://gerrit.wikimedia.org/r/358357

Ladsgroup removed a project: Patch-For-Review.Jul 22 2017, 11:13 AM
Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptJul 22 2017, 11:13 AM
thiemowmde closed this task as Resolved.Oct 24 2017, 4:45 PM
thiemowmde claimed this task.
thiemowmde removed a project: Wikidata-Former-Sprint-Board.

I consider this done with https://github.com/wmde/WikibaseDataModelSerialization/pull/222 and all the changes we did to the Wikibase top level factories. Actually renaming the two (De)SerializerFactories as well as the newEntity(De)Serializer methods is barely worth the hassle.

Please reopen if you strongly disagree.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits