Page MenuHomePhabricator
Create Task
Maniphest T160453

[betalabs-regression] The red highlighting for conflicting filter states is gone
Closed, ResolvedPublic
Actions

Description

  1. On RC page select 'Unregistered' and any of filters in 'Experience level group'.
  2. The red highlighting that should indicate that the filters are in conflict state is nor displayed anymore.
    Screen Shot 2017-03-14 at 11.51.44 AM.png (473×939 px, 99 KB)

Details

SubjectRepoBranchLines +/-
RCFilters UI: Rework conflicts to be objects in filter or group contextmediawiki/coremaster+295 -65
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Mar 14 2017, 6:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2017, 6:53 PM
gerritbot subscribed.Mar 16 2017, 12:03 AM

Change 342284 had a related patch set uploaded (by Mooeypoo):
[mediawiki/core] RCFilters UI: Rework conflicts to be objects in filter or group context

https://gerrit.wikimedia.org/r/342284

gerritbot added a project: Patch-For-Review.Mar 16 2017, 12:03 AM
Jdforrester-WMF assigned this task to Mooeypoo.Mar 16 2017, 1:22 AM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
gerritbot added a comment.Mar 16 2017, 9:41 PM

Change 342284 merged by jenkins-bot:
[mediawiki/core] RCFilters UI: Rework conflicts to be objects in filter or group context

https://gerrit.wikimedia.org/r/342284

Jdforrester-WMF moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Mar 18 2017, 1:41 AM
Etonkovidova added a comment.Mar 19 2017, 7:58 PM

The red highlighting is present (along with added conflict state specific tooltips and the user message):

Screen Shot 2017-03-19 at 12.54.00 PM.png (500×996 px, 76 KB)

QA recommendation: Resolve.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Mar 19 2017, 7:59 PM
• jmatazzoni closed this task as Resolved.Mar 20 2017, 10:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL