Page MenuHomePhabricator

Convert inconsistent font sizes, margins, paddings units... to rem unit
Closed, ResolvedPublic

Event Timeline

debt triaged this task as Low priority.Mar 15 2017, 12:34 AM

Change 342976 had a related patch set uploaded (by JGirault):
[wikimedia/portals] Replace diversity of sizes with predictable rem-based sizes

https://gerrit.wikimedia.org/r/342976

After the patch, we can identify 35 occurrences of font-sizes:

(1rem = 16px)

font-size: 0.8125rem;
font-size: 2rem;
font-size: 85%;
font-size: 75%;
font-size: 1rem;
font-size: inherit;
font-size: 70%;
font-size: 85%;
font-size: 110%;
font-size: 125%;
font-size: larger;
font-size: 0.69rem;
font-size: 0.65rem;
font-size: 0;
font-size: 0.8rem;
font-size: 0.8rem;
font-size: 0.7rem;
font-size: 0.6rem;
font-size: 1.875rem;
font-size: 1rem;
font-size: 0.8rem;
font-size: 0.875rem;
font-size: 0.875rem;
font-size: 0.75rem;
font-size: 0.8125;
font-size: 0.8rem;
font-size: inherit;
font-size: 0.76rem;
font-size: 0.72rem;
font-size: 0.684rem;
font-size: 0.8rem;
font-size: 0.975rem;
font-size: 0.8125;
font-size: 1rem;
font-size: 1rem;

We can see that the list is insanely diverse. The point of this patch is to reproduce the same copy of the portal, without introducing any noticeable changes to font sizes. However, fixing this typographic mess illustrated above, and designing a better typographic scale for the portal (that extends to any wikimedia projects in general), is an important work that needs to be done and I filed the ticket T160704: Design better typographic scale for the portal to follow that work.

Change 344558 had a related patch set uploaded (by JGirault):
[wikimedia/portals@master] Multiply all rem values by 1.6 to scale to 1rem = 10px

https://gerrit.wikimedia.org/r/344558

Change 342976 merged by jenkins-bot:
[wikimedia/portals@master] Replace diversity of sizes with predictable rem-based sizes

https://gerrit.wikimedia.org/r/342976

Change 344558 merged by jenkins-bot:
[wikimedia/portals@master] Multiply all rem values by 1.6 to scale to 1rem = 10px

https://gerrit.wikimedia.org/r/344558

debt added a subscriber: debt.

This was deployed in production on April 11, 2017