Page MenuHomePhabricator
Create Task
Maniphest T160479

[Regression wmf.16] Cursor jumps to the beginning of the page after adding a focusable node
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Insert a focusable node (Math/Template etc.) on the page, the cursor jumps to the beginning to of the article.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Revert "Remove $returnFocusTo hack now null is supported upstream"VisualEditor/VisualEditormaster+11 -5
Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (50a6323d7)mediawiki/extensions/VisualEditorwmf/1.29.0-wmf.16+1 -1
Follow-up Iaa7dffc13: *Actually* allow $returnFocusTo to be nulloojs/uimaster+1 -1
Update VE core submodule to master (5c4c9e8ed)mediawiki/extensions/VisualEditormaster+1 -1
Revert "Remove $returnFocusTo hack now null is supported upstream"VisualEditor/VisualEditorwmf/1.29.0-wmf.16+11 -5
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Mar 14 2017, 11:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2017, 11:08 PM
Ryasmeen updated the task description. (Show Details)Mar 14 2017, 11:08 PM
Jdforrester-WMF triaged this task as Unbreak Now! priority.Mar 16 2017, 2:15 AM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added projects: VisualEditor-ContentEditable, VisualEditor-EditingTools.
Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptMar 16 2017, 2:15 AM
Jdforrester-WMF lowered the priority of this task from Unbreak Now! to High.Mar 16 2017, 2:51 AM
gerritbot subscribed.Mar 16 2017, 11:10 AM

Change 343028 had a related patch set uploaded (by Esanders):
[oojs/ui] Follow-up Iaa7dffc13: *Actually* allow $returnFocusTo to be null

https://gerrit.wikimedia.org/r/343028

gerritbot added a project: Patch-For-Review.Mar 16 2017, 11:10 AM

Change 343029 had a related patch set uploaded (by Esanders):
[VisualEditor/VisualEditor] Revert "Remove $returnFocusTo hack now null is supported upstream"

https://gerrit.wikimedia.org/r/343029

gerritbot added a comment.Mar 16 2017, 3:16 PM

Change 343029 merged by jenkins-bot:
[VisualEditor/VisualEditor] Revert "Remove $returnFocusTo hack now null is supported upstream"

https://gerrit.wikimedia.org/r/343029

gerritbot added a comment.Mar 16 2017, 3:21 PM

Change 343068 had a related patch set uploaded (by Jforrester; owner: Esanders):
[VisualEditor/VisualEditor] Revert "Remove $returnFocusTo hack now null is supported upstream"

https://gerrit.wikimedia.org/r/343068

gerritbot added a comment.Mar 16 2017, 3:25 PM

Change 343071 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor] Update VE core submodule to master (5c4c9e8ed)

https://gerrit.wikimedia.org/r/343071

gerritbot added a comment.Mar 16 2017, 3:25 PM

Change 343028 merged by jenkins-bot:
[oojs/ui] Follow-up Iaa7dffc13: *Actually* allow $returnFocusTo to be null

https://gerrit.wikimedia.org/r/343028

gerritbot added a comment.Mar 16 2017, 3:26 PM

Change 343068 merged by jenkins-bot:
[VisualEditor/VisualEditor] Revert "Remove $returnFocusTo hack now null is supported upstream"

https://gerrit.wikimedia.org/r/343068

gerritbot added a comment.Mar 16 2017, 3:28 PM

Change 343072 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor] Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (rGVED50a6323d7c0a)

https://gerrit.wikimedia.org/r/343072

gerritbot added a comment.Mar 16 2017, 3:47 PM

Change 343071 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] Update VE core submodule to master (5c4c9e8ed)

https://gerrit.wikimedia.org/r/343071

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)).Mar 16 2017, 4:00 PM
Jdforrester-WMF added a comment.Mar 16 2017, 5:26 PM

This is now fixed in master, and we'll deploy it to production in the next hour or so.

gerritbot added a comment.Mar 16 2017, 6:15 PM

Change 343072 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (rGVED50a6323d7c0a)

https://gerrit.wikimedia.org/r/343072

ReleaseTaggerBot edited projects, added MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)); removed MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)).Mar 16 2017, 7:00 PM
Stashbot mentioned this in T154123: VisualEditor: when pasting wikified text from an article, the text style (including link) can't be modified.Mar 16 2017, 7:07 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2017-03-16T19:07:39Z] <thcipriani@tin> Synchronized php-1.29.0-wmf.16/extensions/VisualEditor/lib/ve: SWAT: [[gerrit:343072|Update VE core submodule to wmf/1.29.0-wmf.16 HEAD]] (rGVED50a6323d7c0a) T154123 T160479 (duration: 00m 44s)

Jdforrester-WMF closed this task as Resolved.Mar 16 2017, 7:23 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 16 2017, 7:23 PM
Ryasmeen added a project: Verified.Mar 16 2017, 11:37 PM
Stashbot added a comment.Mar 17 2017, 11:36 PM

Mentioned in SAL (#wikimedia-operations) [2017-03-17T23:36:35Z] <catrope@tin> Synchronized php-1.29.0-wmf.16/extensions/VisualEditor/lib/ve: Fixes for T154123 T160479 T160190 T160197 (duration: 00m 42s)

Stashbot mentioned this in T160190: [Regression wmf.16] Context menus for items below the screen appear broken (no vertical height).Mar 17 2017, 11:36 PM
Stashbot mentioned this in T160197: [Regression wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" .
Jdforrester-WMF added a comment.Mar 17 2017, 11:36 PM

Now re-pushed to production to resolve a deployment issue.

Ryasmeen added projects: Verified-in-Phase0, Verified-in-Phase2.Mar 18 2017, 12:39 AM
Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Apr 12 2017, 11:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits