Page MenuHomePhabricator

[bug] [regression] fix style of user pages in MobileFrontend
Closed, ResolvedPublic

Description

Somehow the alignment for user pages is broken.

three main issues

  1. the gap between subtitle and the actions is messed up
  2. the icon is grey instead of blue (and there is a FOUC)

3. the links should be WMF blue color #3366cc

Event Timeline

β€’ Nirzar renamed this task from Improve style of user pages in MobileFrontend to [bug] [regression] fix style of user pages in MobileFrontend.Mar 16 2017, 12:33 AM
β€’ Nirzar updated the task description. (Show Details)
phuedx added a subscriber: phuedx.

For some reason rEMFR144b4e55a3bc: Fixed 3 issues hasn't been automatically mentioned here…

@phuedx: I am is to blame. I wrote the comment mentioning the gerrit link and forgot to submit it. I just checked it now. I apologize for it.

Sorry, @Wassan.anmol, I didn't mean to imply that you were at fault. You've tagged this task correctly in your commit message, it just hasn't been recognised.

I have been noticing it from my last two tasks. I have to explicitly mention the gerrit link here even after tagging the correct Phab ticket in the commit message.

@wassan.anmol117

can we also make the following change

.heading-holder .tagline {
   margin: 2px 0 0 0; 
}

current padding for heading-holder is 7px.

Note: This will also impact wikidata descriptions on article pages. but that's correct.

the links should be WMF blue color #3366cc

We're using the default link color at the moment (the same as an article) and this colour is not anywhere in core so we shouldn't be using it. I'd like to talk about this separately Nirzar rather than as part of the bug fix.

Jdlrobson added a subscriber: wassan.anmol117.

Over to Nirzar for sign off. Note if we want to change the colour of the links, we should really not do this as part of a bug fix. I wonder if there are similar UI elements e.g. Watchlist "list" and modified? that we could identify and give the same visual treatment. Changing colours in one place (unless we are changing all links?) seems wrong to me. Can you open a ticket?


Change 343024 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend] Fix the margin between username and tagline and color of the talk icon

https://gerrit.wikimedia.org/r/343024

re: link color. sounds good.

The padding under jdlrobson looks double of what it should be.

EddieGP moved this task from Ready for Signoff to Needs More Work on the Reading-Web-Sprint-94 board.

It is, but that seems to be nothing special about the userpage. We've got bottom-padding 7px at the title "Jblrobson" and top-margin 7px at the tagline. We could either just remove the top-margin at ".heading-holder .tagline" (Note to self: resources/skins.minerva.base.styles/pageactions.less line 31), but this changes the padding of taglines in general, having 7 px instead of 14px. Of course we could also use the id tagline-userpage to remove the padding on userpages only. I'd prefer the first, but as it touches other pages would like some kind of approval that this'd be okay and the 14px padding isn't intended.
(Edit: As this is a very simple one, I'll upload the patch for the first option. Whoever thinks going with the first option would be okay can just review the patch, if I should change it just leave me a comment.)

Change 344604 had a related patch set uploaded (by EddieGP):
[mediawiki/extensions/MobileFrontend@master] Remove tagline margin

https://gerrit.wikimedia.org/r/344604

@Nirzar how many pixels should there be between the title and description?

.heading-holder .tagline {
    margin: 4px 0 0;
 }
.heading-holder .tagline {
    margin: 4px 0 0;
 }

amended

Change 344604 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove tagline margin

https://gerrit.wikimedia.org/r/344604

Signed off with Nirzar. FOUC will be tackled separately in T160675
If you want to change the blue colour, please setup a task around consolidating those under header links :)

Change 425729 had a related patch set uploaded (by Niharika29; owner: Niharika29):
[mediawiki/extensions/Thanks@master] Disable thanks for patrol log entries per discussion

https://gerrit.wikimedia.org/r/425729