Page MenuHomePhabricator
Create Task
Maniphest T160494

Update defaults for VisualEditorBrowserBlacklist
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

It's blacklisting msie <= 8 which seems superfluous given MediaWiki core effectively already blacklists that through its feature detection.

After T128115, it can be trimmed even more (at least opera, android blacklisting seems redundant)

Details

SubjectRepoBranchLines +/-
Remove MSIE from blacklist, already blacklisted upstreammediawiki/extensions/VisualEditormaster+0 -16
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Mar 15 2017, 4:29 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptMar 15 2017, 4:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Mar 15 2017, 12:57 PM

Change 342824 had a related patch set uploaded (by Esanders):
[mediawiki/extensions/VisualEditor] Remove MSIE from blacklist, already blacklisted upstream

https://gerrit.wikimedia.org/r/342824

gerritbot added a project: Patch-For-Review.Mar 15 2017, 12:57 PM
Jdforrester-WMF reassigned this task from Jdforrester-WMF to Esanders.Mar 15 2017, 5:45 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF edited projects, added Technical-Debt; removed Patch-For-Review.
Jdforrester-WMF subscribed.
gerritbot added a comment.Mar 15 2017, 6:06 PM

Change 342824 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] Remove MSIE from blacklist, already blacklisted upstream

https://gerrit.wikimedia.org/r/342824

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)).Mar 15 2017, 7:00 PM
Jdforrester-WMF closed this task as Resolved.Mar 15 2017, 7:36 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 15 2017, 7:36 PM
Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Mar 28 2017, 11:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL