Page MenuHomePhabricator

[Task] Improve placeholder image in Commons Media suggester
Closed, ResolvedPublic

Description

The placeholder in the Commons Media suggester is currently just a grey square and looks a bit dull. We should improve it.

Event Timeline

Restricted Application added a project: Design. · View Herald TranscriptMar 15 2017, 2:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Lydia_Pintscher Can you give us more context on this: screenshot of the grey thing for example, and the user need behind it?

Here is a screenshot:

Some of the little preview images are gray squares. This is for the ones where we do not have a preview.

Change 391544 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[data-values/value-view@master] Fix incomplete thumbail CSS in Commons suggester

https://gerrit.wikimedia.org/r/391544

thiemowmde added a project: ValueView.

I realized the missing thumbnails are nothing but a bug in our code, and submitted a patch to fix it.

MediaWiki Commons provides thumbnail images for all file types, even non-visual ones like .midi or .flac.

The gray, shadowed square currently serves three purposes:

  1. To visualize the loading state while a thumbnail is loading. We might want to add a loading spinner or something here, but this is not what this ticket is about.
  2. As a shadow around the thumbnail to make them distinguishable from each other. This is especially important on series of white thumbnails, as seen in the screenshot.
  3. When a thumbnail does not load. But that can only happen if the server does not respond and the request times out. I don't think it's even technically possible to have a special image in this case.

TL;DR: No placeholder image needed.

Change 391544 merged by jenkins-bot:
[data-values/value-view@master] Fix incomplete thumbail CSS in Commons suggester

https://gerrit.wikimedia.org/r/391544

Hanna_Petruschat_WMDE closed this task as Resolved.Feb 26 2018, 1:56 PM