Motivation
Even though the FileExporter already checks the permission rights of the user, we want to make sure that the FileImporter only allows users with enough rights independent of where they come from.
Task
Before loading and after saving the FileExporter specialPage, check if the user is at least autoconfirmed. If they are not logged in, allow them to log in before being redirected to the specialPage. If they don't have enough rights, give them that error message.
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Permission checks | Addshore | mediawiki/extensions/FileImporter | master | +44 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T140462 Correctly move files from Wikipedia to Commons (2013) | |||
| Resolved | thiemowmde | T146666 Build a commons extension that moves files to Commons | |||
| Resolved | Tobi_WMDE_SW | T160543 Don't allow a file import if the user is less than autoconfirmed |
So, this should probably use and check the built in mediawiki right "upload".
Thoughts @Lea_WMDE ?
This could probably actually be a configuration option with the default of 'upload' so that it can easily be altered at a later stage.
Change 344373 had a related patch set uploaded (by Addshore):
[mediawiki/extensions/FileImporter@master] Permission checks
Change 344373 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Permission checks
@Addshore I don't know either. o_O
It should be in done, right? I think we even demoed it..