Don't allow a file import if the user is less than autoconfirmed
Closed, ResolvedPublic


Even though the FileExporter already checks the permission rights of the user, we want to make sure that the FileImporter only allows users with enough rights independent of where they come from.

Before loading and after saving the FileExporter specialPage, check if the user is at least autoconfirmed. If they are not logged in, allow them to log in before being redirected to the specialPage. If they don't have enough rights, give them that error message.

Lea_WMDE created this task.Mar 15 2017, 4:28 PM
Addshore renamed this task from Don't allow a file move if the user is less than autoconfirmed to Don't allow a file import if the user is less than autoconfirmed.Mar 15 2017, 10:39 PM

So, this should probably use and check the built in mediawiki right "upload".
Thoughts @Lea_WMDE ?

This could probably actually be a configuration option with the default of 'upload' so that it can easily be altered at a later stage.

Configuration option with default 'upload' sounds great!

Change 344373 had a related patch set uploaded (by Addshore):
[mediawiki/extensions/FileImporter@master] Permission checks

Change 344373 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Permission checks

@Tobi_WMDE_SW not sure why this one is on watching?

@Addshore I don't know either. o_O
It should be in done, right? I think we even demoed it..

Tobi_WMDE_SW closed this task as Resolved.
Tobi_WMDE_SW claimed this task.
Addshore moved this task from Backlog to Done ✔️ on the User-Addshore board.Aug 22 2017, 4:12 PM