Page MenuHomePhabricator

Invalid CSRF token in Selenium browser test in Popups/MobileFrontend blocking merges
Closed, DuplicatePublic

Description

home/jenkins/workspace/mwext-mw-selenium-jessie/log/junit
12:24:59 @chrome @en.m.wikipedia.beta.wmflabs.org @firefox @test2.m.wikipedia.org @vagrant @integration
12:24:59 Feature: Previews
12:24:59 
12:24:59   Background:                           # features/previews.feature:3
12:25:00     Given I am logged in                # mediawiki_selenium-1.7.3/lib/mediawiki_selenium/step_definitions/login_steps.rb:1
12:25:00       Invalid CSRF token. (badtoken) (MediawikiApi::ApiError)
12:25:00       features/previews.feature:4:in `Given I am logged in'
12:25:00     And I have enabled the beta feature # features/support/step_definitions/common_steps.rb:3
12:25:00     And I am on the test page           # features/support/step_definitions/common_steps.rb:7
12:25:00 
12:25:00   Scenario: Dwelling on a valid link shows a preview # features/previews.feature:8
12:25:00     When I dwell on the first valid link             # features/support/step_definitions/previews.rb:1
12:25:00     Then I should see a preview                      # features/support/step_definitions/previews.rb:9
12:25:00 
12:25:00   Scenario: Abandoning the link hides the preview # features/previews.feature:12
12:25:00     When I dwell on the first valid link          # features/support/step_definitions/previews.rb:1
12:25:00     And I abandon the link                        # features/support/step_definitions/previews.rb:5
12:25:00     Then I should not see a preview               # features/support/step_definitions/previews.rb:13
12:25:00

Event Timeline

Jdlrobson added subscribers: dduvall, zeljkofilipin.

@zeljkofilipin @dduvall seems to be related to mediawiki_selenium - I notice Popups didn't get migrated to Selenium 3 as part of T157695 - could that be the cause?

Jdlrobson renamed this task from Invalid CSRF token in Selenium browser test in Popups blocking merges to Invalid CSRF token in Selenium browser test in Popups/MobileFrontend blocking merges.Mar 16 2017, 12:25 AM
Jdlrobson triaged this task as High priority.
EddieGP raised the priority of this task from High to Unbreak Now!.Mar 16 2017, 1:31 AM
EddieGP added a subscriber: hashar.

Looking into the recent changes dashboard of MobileFrontend and Popups it seems that this prevents any changes to those repositorys to pass any CI check and thus it's currently not possible to merge anything without "overruling" CI.

WMDE has hit that on Wednesday with browser tests and task T160519 has patches attached to it. I +2ed a revert