Investigate why changes to Lexeme entity are not shown on the diff page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	WMDE-leszek
	Mar 16 2017, 9:00 AM

Description

When comparing revision of Lexeme page, diff does not show any differences (while actual changes have been made to the entity), see e.g. http://wikidata-lexeme.wmflabs.org/index.php?title=Lexeme:L5&diff=prev&oldid=12.

There is diff-related code in WikibaseLexeme already. It should be investigated why changes to Lexeme entity do not show up on the diff page.
Once reason for this hsa been tracked down, tickets for fixing the issue should follow.

Details

	Subject	Repo	Branch	Lines +/-
	Add a note in docs for extending entities and EntityDiffVisualizer	mediawiki/extensions/Wikibase	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T161525: gerritbot doesn't add comment/patch-for-review when User:Ladsgroup creates patch in Gerrit
T160656: Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer
Mentioned Here: T160656: Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer

Event Timeline

WMDE-leszek created this task.Mar 16 2017, 9:00 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2017, 9:00 AM

WMDE-leszek triaged this task as Medium priority.Mar 16 2017, 9:08 AM

The class behind this issue is EntityDiffVisualizer It's even hard-coded item parts in it with a fixme. I have this way of refactoring it in mind:

Have the EntityDiffViewFactory interface that returns instances of DiffView, get it implemented in different entity types using entity type definition class. And use it in EntityDiffVisualizer

How that sounds?

WMDE-leszek added a subscriber: daniel.Mar 16 2017, 3:58 PM

WMDE-leszek renamed this task from Investiage why changes to Lexeme entity are not shown on the diff page to Investigate why changes to Lexeme entity are not shown on the diff page.Mar 16 2017, 4:21 PM

Ladsgroup mentioned this in T160656: Build EntityDiffViewFactory for different entity types and use it in EntityDiffVisualizer.Mar 16 2017, 4:36 PM

Since the fix in gerrit-bot is not there yet: https://gerrit.wikimedia.org/r/343902

Ladsgroup claimed this task.Mar 21 2017, 4:01 PM

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMar 21 2017, 4:01 PM

Ladsgroup moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.Mar 21 2017, 4:01 PM

Ladsgroup moved this task from Incoming to Blocked on others on the User-Ladsgroup board.

Change 343902 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Add a note in docs for extending entities and EntityDiffVisualizer

https://gerrit.wikimedia.org/r/343902

Investigation is done, thanks @Ladsgroup. Ticket for fixing the identified issue is T160656.

Ladsgroup mentioned this in T161525: gerritbot doesn't add comment/patch-for-review when User:Ladsgroup creates patch in Gerrit.Mar 27 2017, 3:50 PM

Ladsgroup moved this task from Blocked on others to Done on the User-Ladsgroup board.Apr 9 2017, 9:29 AM

Investigate why changes to Lexeme entity are not shown on the diff pageClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Investigate why changes to Lexeme entity are not shown on the diff page
Closed, ResolvedPublic
Actions