Maniphest T160617

[se-fornmin] Finalize processing code
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Make sure that the preview page is ready for release.

Add reporting of unmatched values.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Alicia_Fagerving_WMSE	T160340 [se-fornmin] Create preview page
		Resolved		Alicia_Fagerving_WMSE	T160617 [se-fornmin] Finalize processing code

Event Timeline

Alicia_Fagerving_WMSE created this task.Mar 16 2017, 9:19 AM

PR: https://github.com/Vesihiisi/COH-tools/pull/46

Alicia_Fagerving_WMSE added a project: Patch-For-Review.Mar 16 2017, 9:29 AM

Alicia_Fagerving_WMSE moved this task from 🗃️ Inbox to ♾️ Watching on the User-Alicia_Fagerving_WMSE board.Mar 16 2017, 9:38 AM

Lokal_Profil added a project: User-LokalProfil.Mar 21 2017, 5:43 PM

Lokal_Profil moved this task from 📥 Backlog to 🔬 to Review on the User-LokalProfil board.

Lokal_Profil moved this task from Backlog to In process on the Connected-Open-Heritage-Wikidata-migration (se-fornmin) board.

The patch looks good (just two questions) but I would like the issues around [[ https://github.com/Vesihiisi/COH-tools/pull/47#discussion_r107470744 | add_statement in se-bbr - Finalize processing code ]] and T161114: Make the check for existing item more versatile be resolved before moving on with an upload.

The add_statement thing is moved to T161303, and up for review, and so is T161114.

Alicia_Fagerving_WMSE moved this task from ♾️ Watching to 📆 This week on the User-Alicia_Fagerving_WMSE board.Mar 27 2017, 11:28 AM

Alicia_Fagerving_WMSE set the point value for this task to 3.

Merged: https://github.com/Vesihiisi/COH-tools/commit/4b792f243db4c0210aded25abd830b4ba3d966be

Alicia_Fagerving_WMSE moved this task from 📆 This week to ☑️ Done on the User-Alicia_Fagerving_WMSE board.Mar 28 2017, 11:17 AM

Alicia_Fagerving_WMSE removed a project: Patch-For-Review.Mar 29 2017, 11:42 AM

Alicia_Fagerving_WMSE moved this task from In process to Done on the Connected-Open-Heritage-Wikidata-migration (se-fornmin) board.Mar 29 2017, 2:16 PM

Lokal_Profil moved this task from 🔬 to Review to ☑️ Done on the User-LokalProfil board.Mar 29 2017, 4:01 PM

Alicia_Fagerving_WMSE closed this task as Resolved.May 15 2017, 11:40 AM